Fix/remove constant none checks

backend/tests/apps/slack/common/question_detector_test.py

@@ -176,7 +176,8 @@ def test_mocked_initialization(self):
             detector = QuestionDetector()
 
             # Test that detector initializes properly
-            assert detector is not None
+            assert isinstance(detector, QuestionDetector)
+
             assert hasattr(detector, "openai_client")
             assert hasattr(detector, "retriever")
 

frontend/src/app/members/[memberKey]/page.tsx

@@ -57,13 +57,13 @@ const UserDetailsPage: React.FC = () => {
 
   useEffect(() => {
     const fetchData = async () => {
-      const result = await fetchHeatmapData(memberKey as string)
+      const result = await fetchHeatmapData(memberKey)
       if (!result) {
         setIsPrivateContributor(true)
         return
       }
       if (result?.contributions) {
-        setUsername(memberKey as string)
+        setUsername(memberKey)
         setData(result as HeatmapData)
       }
     }

frontend/src/components/CardDetailsPage.tsx

@@ -127,7 +127,7 @@ const DetailsCard = ({
               {type === 'module' &&
                 accessLevel === 'admin' &&
                 admins?.some(
-                  (admin) => admin.login === ((data as ExtendedSession)?.user?.login as string)
+                  (admin) => admin.login === ((data as ExtendedSession)?.user?.login)
                 ) && <EntityActions type="module" programKey={programKey} moduleKey={entityKey} />}
               {!isActive && <StatusBadge status="inactive" size="md" />}
               {isArchived && type === 'repository' && <StatusBadge status="archived" size="md" />}

frontend/src/components/ChapterMap.tsx

@@ -62,7 +62,7 @@ const ChapterMap = ({
       })
 
       mapRef.current.on('mouseout', (e: L.LeafletMouseEvent) => {
-        const originalEvent = e.originalEvent as MouseEvent
+        const originalEvent = e.originalEvent
         const relatedTarget = originalEvent.relatedTarget as Node | null
         const container = mapRef.current?.getContainer()
         const mapParent = container?.parentElement

frontend/src/components/MultiSearch.tsx

@@ -62,7 +62,7 @@ const MultiSearchBar: React.FC<MultiSearchBarProps> = ({
           if (filteredEvents.length > 0) {
             results.push({
               indexName: 'events',
-              hits: filteredEvents.slice(0, suggestionCount) as Event[],
+              hits: filteredEvents.slice(0, suggestionCount),
               totalPages: 1,
             })
           }

frontend/src/components/SingleModuleCard.tsx

@@ -28,7 +28,7 @@ const SingleModuleCard: React.FC<SingleModuleCardProps> = ({ module, accessLevel
 
   const isAdmin =
     accessLevel === 'admin' &&
-    admins?.some((admin) => admin.login === ((data as ExtendedSession)?.user?.login as string))
+    admins?.some((admin) => admin.login === ((data as ExtendedSession)?.user?.login))
 
   // Extract programKey from pathname (e.g., /my/mentorship/programs/[programKey])
   const programKey = pathname?.split('/programs/')[1]?.split('/')[0] || ''

frontend/src/components/UserMenu.tsx

@@ -7,7 +7,6 @@ import Link from 'next/link'
 import { signIn } from 'next-auth/react'
 import { useEffect, useId, useRef, useState } from 'react'
 import { FaGithub } from 'react-icons/fa'
-import { ExtendedSession } from 'types/auth'
 
 export default function UserMenu({
   isGitHubAuthEnabled,
@@ -19,7 +18,7 @@ export default function UserMenu({
   const [isOpen, setIsOpen] = useState(false)
   const dropdownRef = useRef<HTMLDivElement>(null)
   const dropdownId = useId()
-  const isProjectLeader = (session as ExtendedSession)?.user?.isLeader
+  const isProjectLeader = (session)?.user?.isLeader
   const isOwaspStaff = session?.user?.isOwaspStaff
 
   useEffect(() => {

frontend/src/hooks/useSearchPage.ts

@@ -104,7 +104,7 @@ export function useSearchPage<T>({
 
         if ('hits' in response) {
           setItems(response.hits)
-          setTotalPages(response.totalPages as number)
+          setTotalPages(response.totalPages)
         } else {
           handleAppError(response)
         }

frontend/src/utils/env.server.ts

@@ -1,5 +1,5 @@
-export const GITHUB_CLIENT_ID = process.env.NEXT_SERVER_GITHUB_CLIENT_ID!
-export const GITHUB_CLIENT_SECRET = process.env.NEXT_SERVER_GITHUB_CLIENT_SECRET!
+export const GITHUB_CLIENT_ID = process.env.NEXT_SERVER_GITHUB_CLIENT_ID
+export const GITHUB_CLIENT_SECRET = process.env.NEXT_SERVER_GITHUB_CLIENT_SECRET
 export const NEXTAUTH_URL = process.env.NEXTAUTH_URL
 
 export const IS_GITHUB_AUTH_ENABLED = Boolean(GITHUB_CLIENT_ID && GITHUB_CLIENT_SECRET)