Skip to content

fix(ci): correct ZAP baseline report filename to avoid upload failure #3246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arkid15r merged 9 commits into from
Jan 9, 2026
Merged

fix(ci): correct ZAP baseline report filename to avoid upload failure #3246

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
795f055
fix(ci): correct ZAP baseline report filename to avoid upload failure
nios-x Jan 8, 2026
68792e9
fix(ci): correct ZAP baseline report filename to avoid upload failure
nios-x Jan 8, 2026
afe44a4
Merge branch 'main' into zap
nios-x Jan 8, 2026
698465b
Merge branch 'main' into pr/nios-x/3246
arkid15r Jan 8, 2026
563cdb8
Update code
arkid15r Jan 8, 2026
d4b5060
Merge branch 'main' into zap
nios-x Jan 9, 2026
8b5d675
fix(ci): correct ZAP baseline report filename to avoid upload failure
nios-x Jan 9, 2026
331a39d
Update code
arkid15r Jan 9, 2026
56c9819
Merge branch 'main' into zap
arkid15r Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions .github/workflows/run-ci-cd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,15 +621,14 @@ jobs:
target: 'https://nest.owasp.dev'
allow_issue_writing: false
fail_action: false
cmd_options: '-a -c .zapconfig -r report.html '
cmd_options: '-a -c .zapconfig -r report_html.html'

- name: Upload report
if: always()
uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f
with:
name: zap-baseline-scan-report-${{ github.run_id }}
path: report.html

path: report_html.html
Copy link
Collaborator

@arkid15r arkid15r Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So your code just renamed the report file. Why do you think it'll work now if it didn't work for the same approach with just a different name?

Copy link
Contributor Author

@nios-x nios-x Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously, I removed the report file generation step because I initially thought that was causing the issue.
This time, I addressed the actual root cause by properly renaming and aligning the report filename, which was mismatched between the ZAP generation step and the artifact upload step and was causing the failure.


build-production-images:
name: Build Production Images
Expand Down Expand Up @@ -965,11 +964,11 @@ jobs:
target: 'https://nest.owasp.org'
allow_issue_writing: false
fail_action: false
cmd_options: '-a -c .zapconfig -r report.html '
cmd_options: '-a -c .zapconfig -r report_html.html'

- name: Upload report
if: always()
uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f
with:
name: zap-baseline-scan-report-${{ github.run_id }}
path: report.html
path: report_html.html