fix: resolve ZAP baseline scan report filename mismatch#3188
Closed
HarshitVerma109 wants to merge 1 commit intoOWASP:mainfrom
Closed
fix: resolve ZAP baseline scan report filename mismatch#3188HarshitVerma109 wants to merge 1 commit intoOWASP:mainfrom
HarshitVerma109 wants to merge 1 commit intoOWASP:mainfrom
Conversation
- Remove -r zap-report.html from cmd_options to use default filename - Update artifact upload path to report_html.html - Fixes both staging and production scan jobs - Resolves issue where action expected report_html.html but got zap-report.html
Contributor
WalkthroughTwo ZAP baseline scan CI jobs in the GitHub Actions workflow were reconfigured. The scan command flag Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Contributor
Author
|
@arkid15r |
Collaborator
|
Closing in favor of #3198 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Proposed change
Resolves #3183
This PR fixes the CI/CD pipeline failure in the ZAP Baseline Scan jobs. The
zaproxy/action-baselineaction expects the HTML report to be namedreport_html.htmlby default, but the workflow configuration was overriding this with-r zap-report.htmlincmd_options, causing a file not found error.Changes made:
-r zap-report.htmlfromcmd_optionsto use default filenamereport_html.htmlreport_html.htmlbut gotzap-report.htmlFiles modified:
.github/workflows/run-ci-cd.yamlChecklist
make check-testlocally and all tests passed