Skip to content

Fix breadcrumb overflow for long chapter names on small screens #2972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kasya merged 1 commit into from
Dec 21, 2025
Merged

Fix breadcrumb overflow for long chapter names on small screens #2972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion frontend/__tests__/unit/components/BreadCrumbs.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@ describe('BreadCrumbRenderer', () => {
render(<BreadCrumbRenderer items={mockItems} />)

const lastItem = screen.getByText('OWASP ZAP')
expect(lastItem).toHaveClass('cursor-default', 'font-semibold')
const parentSpan = lastItem.parentElement
expect(parentSpan).toHaveClass('cursor-default', 'font-semibold')
})

test('renders chevron separators between items', () => {
Expand Down
11 changes: 9 additions & 2 deletions frontend/src/components/BreadCrumbs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { Breadcrumbs, BreadcrumbItem as HeroUIBreadcrumbItem } from '@heroui/rea
import Link from 'next/link'
import { FaChevronRight } from 'react-icons/fa'
import type { BreadcrumbItem } from 'types/breadcrumb'
import { TruncatedText } from 'components/TruncatedText'

type BreadCrumbRendererProps = Readonly<{
items: readonly BreadcrumbItem[]
Expand Down Expand Up @@ -31,14 +32,20 @@ export default function BreadCrumbRenderer({ items }: BreadCrumbRendererProps) {
className="cursor-default font-semibold text-gray-600 dark:text-gray-300"
aria-current="page"
>
{item.title}
<TruncatedText
text={item.title}
className="max-w-xs sm:max-w-sm md:max-w-none"
/>
</span>
) : (
<Link
href={item.path}
className="hover:text-blue-700 hover:underline dark:text-blue-400"
>
{item.title}
<TruncatedText
text={item.title}
className="max-w-xs sm:max-w-sm md:max-w-none"
/>
</Link>
)}
</HeroUIBreadcrumbItem>
Expand Down
13 changes: 10 additions & 3 deletions frontend/src/components/BreadCrumbsWrapper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { useBreadcrumbs } from 'hooks/useBreadcrumbs'
import Link from 'next/link'
import { usePathname } from 'next/navigation'
import { FaChevronRight } from 'react-icons/fa6'
import { TruncatedText } from 'components/TruncatedText'

export default function BreadCrumbsWrapper() {
const pathname = usePathname()
Expand All @@ -20,7 +21,7 @@ export default function BreadCrumbsWrapper() {
separator={<FaChevronRight className="mx-1 text-xs text-gray-400 dark:text-gray-500" />}
className="text-gray-800 dark:text-gray-200"
itemClasses={{
base: 'transition-colors duration-200',
base: 'transition-colors duration-200 min-w-0',
item: 'text-sm font-medium',
separator: 'flex items-center',
}}
Expand All @@ -32,14 +33,20 @@ export default function BreadCrumbsWrapper() {
<HeroUIBreadcrumbItem key={item.path} isDisabled={isLast}>
{isLast ? (
<span className="cursor-default font-semibold text-gray-800 dark:text-gray-100">
{item.title}
<TruncatedText
text={item.title}
className="max-w-xs sm:max-w-sm md:max-w-none"
/>
</span>
) : (
<Link
href={item.path}
className="hover:text-blue-700 hover:underline dark:text-blue-400"
>
{item.title}
<TruncatedText
text={item.title}
className="max-w-xs sm:max-w-sm md:max-w-none"
/>
</Link>
)}
</HeroUIBreadcrumbItem>
Expand Down