feat: update map overlay to "Unlock map" with hover effect#2925
feat: update map overlay to "Unlock map" with hover effect#2925swankystark wants to merge 2 commits intoOWASP:mainfrom
Conversation
- Changed overlay text from 'Click to interact with map' to 'Unlock map' - Added unlock icon (faLockOpen) from FontAwesome before text - Updated aria-label for better accessibility - Updated all related unit tests All tests passing (30/30)
|
Caution Review failedThe pull request is closed. Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings. WalkthroughThis PR updates the ChapterMap component's overlay button to display "Unlock map" with a lock-open icon instead of "Click to interact with map". The component now imports FontAwesome icons, adds flex layout styling to the button label, and updates the aria-label accordingly. Corresponding test assertions are updated to match the new text and UI changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The linked issue must be assigned to the PR author. |
|



Proposed change
Related to #2839
This PR updates the map interaction overlay to specific "Unlock map" actions with visual improvements, addressing feedback from the previous PR.
Changes:
faLockOpen) from FontAwesome before the text.hover:scale-105) and brightens on hover for clearer interactivity.aria-labelto "Unlock map" for better accessibility.Verification:
make check-testin WSL environment and all checks passed (including linting and unit tests).Checklist
make check-testlocally and all tests passed