Skip to content

Fixed inconsistent UI of clear search icon across all search bars #2866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kasya merged 11 commits into from
Dec 13, 2025
Merged

Fixed inconsistent UI of clear search icon across all search bars #2866

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f97be75
Fixed ui: added text color to clear search icon
anirudhprmar Dec 10, 2025
af3a600
Fixed ui : made the clear search icon round, added styles to support …
anirudhprmar Dec 11, 2025
f684129
added bg and proper hover state to home page clear search icon
anirudhprmar Dec 11, 2025
018ca1f
Unify bg color and run make check
kasya Dec 12, 2025
1fb937e
Fix removed classes
kasya Dec 12, 2025
3923ee6
Add focus
kasya Dec 12, 2025
f4f3fe0
Fix tests
kasya Dec 12, 2025
5ad3730
Merge branch 'main' into fix/inconsistent-ui
anirudhprmar Dec 12, 2025
a76822d
Merge branch 'main' into fix/inconsistent-ui
anirudhprmar Dec 13, 2025
bea1d4e
Merge branch 'main' into fix/inconsistent-ui
kasya Dec 13, 2025
ce83897
Update button styling and update tests
kasya Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions frontend/__tests__/unit/components/Search.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,15 +73,15 @@ describe('SearchBar Component', () => {
const { container } = render(<SearchBar {...defaultProps} isLoaded={false} />)
const input = screen.getByPlaceholderText('Search projects...')
expect(input).toHaveValue('')
const clearButton = container.querySelector('button.absolute.rounded-full[class*="right-2"]')
const clearButton = container.querySelector('button.absolute.rounded-md[class*="right-2"]')
expect(clearButton).not.toBeInTheDocument()
})

it('shows clear button when searchQuery is not empty', () => {
const { container } = render(<SearchBar {...defaultProps} isLoaded={false} />)
const input = screen.getByPlaceholderText('Search projects...')
fireEvent.change(input, { target: { value: 'test' } })
const clearButton = container.querySelector('button.absolute.rounded-full[class*="right-2"]')
const clearButton = container.querySelector('button.absolute.rounded-md[class*="right-2"]')
expect(clearButton).toBeInTheDocument()
})
})
Expand Down Expand Up @@ -145,7 +145,7 @@ describe('SearchBar Component', () => {
const input = screen.getByPlaceholderText('Search projects...')
fireEvent.change(input, { target: { value: 'test' } })
expect(input).toHaveValue('test')
const clearButton = container.querySelector('button.absolute.rounded-full[class*="right-2"]')
const clearButton = container.querySelector('button.absolute.rounded-md[class*="right-2"]')
fireEvent.click(clearButton)
expect(input).toHaveValue('')
})
Expand Down Expand Up @@ -312,7 +312,7 @@ describe('SearchBar Component', () => {
fireEvent.change(input, { target: { value: 'edge case' } })
expect(mockOnSearch).not.toHaveBeenCalled()

const clearButton = container.querySelector('button.absolute.rounded-full[class*="right-2"]')
const clearButton = container.querySelector('button.absolute.rounded-md[class*="right-2"]')
fireEvent.click(clearButton)

jest.advanceTimersByTime(750)
Expand All @@ -332,10 +332,10 @@ describe('SearchBar Component', () => {
const input = screen.getByPlaceholderText('Search projects...')
expect(input).toBeInTheDocument()
expect(input).toHaveAttribute('type', 'text')
let clearButton = container.querySelector('button.absolute.rounded-full[class*="right-2"]')
let clearButton = container.querySelector('button.absolute.rounded-md[class*="right-2"]')
expect(clearButton).not.toBeInTheDocument()
fireEvent.change(input, { target: { value: 'test' } })
clearButton = container.querySelector('button.absolute.rounded-full[class*="right-2"]')
clearButton = container.querySelector('button.absolute.rounded-md[class*="right-2"]')
expect(clearButton).toBeInTheDocument()
})

Expand Down Expand Up @@ -366,9 +366,9 @@ describe('SearchBar Component', () => {
const { container } = render(<SearchBar {...defaultProps} isLoaded={false} />)
const input = screen.getByPlaceholderText('Search projects...')
fireEvent.change(input, { target: { value: 'test' } })
const clearButton = container.querySelector('button.absolute.rounded-full[class*="right-2"]')
const clearButton = container.querySelector('button.absolute.rounded-md[class*="right-2"]')
expect(clearButton).toHaveClass(
'absolute right-2 top-1/2 -translate-y-1/2 rounded-full p-1 hover:bg-gray-100 focus:outline-hidden focus:ring-2 focus:ring-gray-300'
'absolute top-1/2 right-2 h-8 w-8 -translate-y-1/2 rounded-md p-1 text-gray-400 hover:bg-gray-400 hover:text-gray-200 focus:ring-2 focus:ring-gray-300 focus:outline-hidden dark:hover:bg-gray-600'
)
})

Expand Down
2 changes: 1 addition & 1 deletion frontend/src/components/MultiSearch.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ const MultiSearchBar: React.FC<MultiSearchBarProps> = ({
{searchQuery && (
<button
type="button"
className="absolute top-1/2 right-2 -translate-y-1/2 rounded-full p-1 text-gray-400 hover:text-gray-600"
className="absolute top-1/2 right-2 h-8 w-8 -translate-y-1/2 rounded-md p-1 text-gray-400 hover:bg-gray-400 hover:text-gray-200 focus:ring-2 focus:ring-gray-300 focus:outline-hidden dark:hover:bg-gray-600"
onClick={handleClearSearch}
aria-label="Clear search"
>
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/components/Search.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ const SearchBar: React.FC<SearchProps> = ({
{searchQuery && (
<button
type="button"
className="absolute top-1/2 right-2 -translate-y-1/2 rounded-full p-1 hover:bg-gray-100 focus:ring-2 focus:ring-gray-300 focus:outline-hidden"
className="absolute top-1/2 right-2 h-8 w-8 -translate-y-1/2 rounded-md p-1 text-gray-400 hover:bg-gray-400 hover:text-gray-200 focus:ring-2 focus:ring-gray-300 focus:outline-hidden dark:hover:bg-gray-600"
onClick={handleClearSearch}
aria-label="Clear search"
>
Expand Down