Fix equality checks with floating point values

[kasya]

Fix for equality checks with floating point values in backend tests.

Checklist

• I've read and followed the contributing guidelines.
• I've run make check-test locally; all checks and tests passed.

[coderabbitai]

Summary by CodeRabbit

• Tests
  • Enhanced assertions for floating-point constants across multiple test modules to improve reliability and robustness.

Walkthrough

Two test files have been updated to replace direct floating-point equality assertions with tolerance-based comparisons using math.isclose(). The changes add import math and modify existing test assertions to accommodate floating-point representation differences while preserving test behavior.

Changes

Cohort / File(s)	Summary
Floating-point comparison robustness in tests backend/tests/apps/ai/agent/tools/rag/generator_test.py, backend/tests/apps/slack/common/question_detector_test.py	Added import math and replaced direct equality checks (==) with math.isclose() for TEMPERATURE constant assertions to tolerate floating-point representation differences

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

• Both changes follow an identical pattern (import math, update one assertion)
• No production code modifications
• Simple, repetitive test assertion updates with clear intent

Possibly related PRs

• Fixed an issue with equality checks on floating point values #2510: Replaces floating-point equality checks with tolerance-based comparisons (using math.isclose/pytest.approx) in backend tests, following the same pattern.

Suggested labels

backend, backend-tests

Suggested reviewers

• arkid15r

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: converting equality checks to use math.isclose for floating-point comparison.
Description check	✅ Passed	The description clearly relates to the changeset, explaining the fix addresses floating-point equality checks in backend tests.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-float-comparison

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 68d7e5e and c6e8261.

📒 Files selected for processing (2)

• backend/tests/apps/ai/agent/tools/rag/generator_test.py (2 hunks)
• backend/tests/apps/slack/common/question_detector_test.py (2 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

backend/tests/apps/ai/agent/tools/rag/generator_test.py (1)

backend/apps/ai/agent/tools/rag/generator.py (1)

• Generator (15-119)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: Run Code Scan
• GitHub Check: Run CI Denendencies Scan
• GitHub Check: CodeQL (javascript-typescript)

🔇 Additional comments (2)

backend/tests/apps/slack/common/question_detector_test.py (1)

3-3: LGTM! Correct approach for floating-point comparison.

Using math.isclose() instead of direct equality is the appropriate way to handle floating-point comparisons in Python, avoiding potential precision issues from binary representation of decimal numbers.

Also applies to: 186-186

backend/tests/apps/ai/agent/tools/rag/generator_test.py (1)

3-3: LGTM! Correct approach for floating-point comparison.

Using math.isclose() instead of direct equality properly handles floating-point representation differences and follows Python best practices for numeric comparisons.

Also applies to: 324-324

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud