- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 250
Add entity_channel field to Reminder model and remove channel_id #2399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            ahmedxgouda
  wants to merge
  8
  commits into
  OWASP:feature/nestbot-calendar-events
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
ahmedxgouda:nestbot-calendar/entity-channel
  
      
      
   
  
    
  
  
  
 
  
      
    base: feature/nestbot-calendar-events
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
  
     Open
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            8 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      2711823
              
                Update poetry lock
              
              
                ahmedxgouda f4e82af
              
                Merge migrations
              
              
                ahmedxgouda e4b2878
              
                Add channel and remove channel id
              
              
                ahmedxgouda 1b030b2
              
                Update logic and refactor
              
              
                ahmedxgouda 4e18dcd
              
                Fix bugs
              
              
                ahmedxgouda 9133fa3
              
                Fix bugs, make entity channel non-nullable, and add send_and_delete m…
              
              
                ahmedxgouda 45952dc
              
                Update tests
              
              
                ahmedxgouda a9b2c15
              
                Update tests
              
              
                ahmedxgouda File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
          Some comments aren't visible on the classic Files Changed page.
        
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
        
          
  
    
      
          
            29 changes: 29 additions & 0 deletions
          
          29 
        
  backend/apps/nest/migrations/0014_remove_reminder_channel_id_reminder_entity_channel.py
  
  
      
      
   
        
      
      
    
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| # Generated by Django 5.2.6 on 2025-10-08 15:16 | ||
|  | ||
| import django.db.models.deletion | ||
| from django.db import migrations, models | ||
|  | ||
|  | ||
| class Migration(migrations.Migration): | ||
| dependencies = [ | ||
| ("nest", "0013_merge_0006_delete_apikey_0012_reminderschedule_job_id"), | ||
| ("owasp", "0055_merge_20251008_1253"), | ||
| ] | ||
|  | ||
| operations = [ | ||
| migrations.RemoveField( | ||
| model_name="reminder", | ||
| name="channel_id", | ||
| ), | ||
| migrations.AddField( | ||
| model_name="reminder", | ||
| name="entity_channel", | ||
| field=models.ForeignKey( | ||
| null=True, | ||
| on_delete=django.db.models.deletion.CASCADE, | ||
| related_name="reminders", | ||
| to="owasp.entitychannel", | ||
| verbose_name="Channel", | ||
| ), | ||
| ), | ||
| ] | ||
        
          
  
    
      
          
            24 changes: 24 additions & 0 deletions
          
          24 
        
  backend/apps/nest/migrations/0015_alter_reminder_entity_channel.py
  
  
      
      
   
        
      
      
    
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| # Generated by Django 5.2.6 on 2025-10-09 12:45 | ||
|  | ||
| import django.db.models.deletion | ||
| from django.db import migrations, models | ||
|  | ||
|  | ||
| class Migration(migrations.Migration): | ||
| dependencies = [ | ||
| ("nest", "0014_remove_reminder_channel_id_reminder_entity_channel"), | ||
| ("owasp", "0055_merge_20251008_1253"), | ||
| ] | ||
|  | ||
| operations = [ | ||
| migrations.AlterField( | ||
| model_name="reminder", | ||
| name="entity_channel", | ||
| field=models.ForeignKey( | ||
| on_delete=django.db.models.deletion.CASCADE, | ||
| related_name="reminders", | ||
| to="owasp.entitychannel", | ||
| verbose_name="Channel", | ||
| ), | ||
| ), | ||
| ] | 
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| # Generated by Django 5.2.6 on 2025-10-08 12:53 | ||
|  | ||
| from django.db import migrations | ||
|  | ||
|  | ||
| class Migration(migrations.Migration): | ||
| dependencies = [ | ||
| ("owasp", "0053_merge_20250918_1659"), | ||
| ("owasp", "0054_event_event_end_date_desc_idx"), | ||
| ] | ||
|  | ||
| operations = [] | 
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Uh oh!
There was an error while loading. Please reload this page.