Skip to content

enhancement/Migrate frontend to TypeScript 5.9#2360

Merged
arkid15r merged 2 commits intoOWASP:mainfrom
Mariam-Saeed:Migrate-frontend-to-TypeScript-5.9
Oct 4, 2025
Merged

enhancement/Migrate frontend to TypeScript 5.9#2360
arkid15r merged 2 commits intoOWASP:mainfrom
Mariam-Saeed:Migrate-frontend-to-TypeScript-5.9

Conversation

@Mariam-Saeed
Copy link
Contributor

Proposed change

Resolves #2353

  1. Update TypeScript version to 5.9 in package.json.
  2. Run pnpm install to update pnpm-lock.yaml
  3. Fix TypeScript 5.9 compatibility by removing the TextEncoder polyfill (native in Node.js 18+) in jest.setup.ts
  4. Verify build and type checking pass.

Checklist

  • I've read and followed the contributing guidelines.
  • I've run make check-test locally; all checks and tests passed.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 4, 2025

Summary by CodeRabbit

  • Tests
    • Removed a global encoding polyfill from the test setup. No impact on user-facing functionality.
  • Chores
    • Updated TypeScript dev dependency to ~5.9.0. No runtime changes.

Walkthrough

Bumps frontend TypeScript to ~5.9.0 in package.json and removes the TextEncoder polyfill import/assignment from frontend/jest.setup.ts. No exported/public APIs were changed.

Changes

Cohort / File(s) Change summary
Tooling: TypeScript version bump
frontend/package.json
Updated devDependencies TypeScript from ~5.8.3 to ~5.9.0.
Test setup adjustment
frontend/jest.setup.ts
Removed TextEncoder import from util and removed assignment to global.TextEncoder.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Title Check ✅ Passed The title accurately summarizes the primary change of migrating the frontend to TypeScript 5.9 and clearly reflects the main intent of the changeset, making it easy for reviewers to understand the focus at a glance.
Linked Issues Check ✅ Passed The pull request updates the frontend to TypeScript 5.9 and removes the TextEncoder polyfill as required by issue #2353, thereby fully satisfying the linked issue’s coding objectives for migration and compatibility fixes.
Out of Scope Changes Check ✅ Passed All modifications are confined to updating the TypeScript version and removing the polyfill in test setup, which align precisely with the migration objectives, and no unrelated changes are present.
Description Check ✅ Passed The description clearly outlines the update of the TypeScript version, the removal of the TextEncoder polyfill, and verification steps, and it directly references the resolved issue, so it is fully on-topic with the changeset.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5671516 and 981b676.

⛔ Files ignored due to path filters (1)
  • frontend/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • frontend/package.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Run frontend unit tests
  • GitHub Check: Run backend tests
  • GitHub Check: Run frontend e2e tests
🔇 Additional comments (1)
frontend/package.json (1)

117-117: TypeScript 5.9 bump looks good.

The version upgrade aligns with the migration goal and remains compatible with the existing toolchain.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2025

@arkid15r arkid15r enabled auto-merge October 4, 2025 16:58
@arkid15r arkid15r added this pull request to the merge queue Oct 4, 2025
Merged via the queue into OWASP:main with commit d684e1f Oct 4, 2025
25 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Feb 5, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate frontend to TypeScript 5.9

2 participants