-
-
Notifications
You must be signed in to change notification settings - Fork 271
feat(deps): Update font-awesome dependies to fix test errors #2286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary by CodeRabbit
WalkthroughUpdated FontAwesome packages in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
frontend/package.json (1)
26-26: Nit: JSON spacing deviates from Prettier config.Add a space after the colon to match the rest of the file and avoid churn on format runs.
- "@fortawesome/react-fontawesome":"^3.0.2", + "@fortawesome/react-fontawesome": "^3.0.2",
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
frontend/package.json(1 hunks)
🔇 Additional comments (2)
frontend/package.json (2)
22-26: Action: confirm FontAwesome v7 / react-fontawesome v3 impact (dynamic imports & fixed‑width icons)
- frontend/package.json added @fortawesome/*@^7.0.1 and @fortawesome/react-fontawesome@^3.0.2.
- Repo search returned no FontAwesome usages (FontAwesomeIcon, library.add, dynamic imports), but ripgrep showed file-skip warnings — manually verify there are no dynamic icon imports and update any snapshot/layout tests that assume pre‑v7 (non‑fixed) widths.
22-25: FA v7 bump looks correct — run a clean reinstall in frontendfrontend/package.json now pins @fortawesome/*@^7.0.1 and @fortawesome/react-fontawesome@^3.0.2 (FA v7 + React v3). Remove stale lockfile entries in the frontend and reinstall to avoid resolution mismatches.
cd frontend rm -f pnpm-lock.yaml package-lock.json yarn.lock pnpm install
|
|
@dharapandya85 you must run mandatory checks and tests for your code. |



Proposed change
Resolves #2210
This PR addresses the issue of build failure. It updates the font-awesome dependencies with latest version.
Checklist
make check-testlocally; all checks and tests passed.