Skip to content

Conversation

@dharapandya85
Copy link
Contributor

Proposed change

Resolves #2210

This PR addresses the issue of build failure. It updates the font-awesome dependencies with latest version.

Checklist

  • I've read and followed the contributing guidelines.
  • I've run make check-test locally; all checks and tests passed.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 16, 2025

Summary by CodeRabbit

  • Chores
    • Updated FontAwesome icon libraries to v7.0.1 in the frontend (@fortawesome/fontawesome-svg-core, free-brands-svg-icons, free-regular-svg-icons, free-solid-svg-icons).
    • Kept @fortawesome/react-fontawesome unchanged.
    • No changes to public APIs or user-facing flows expected.
    • Potential minor visual refinements to icons due to upstream updates.
    • Low-risk update with no application code changes.

Walkthrough

Updated FontAwesome packages in frontend/package.json: bumped core and icon packs from 6.7.2 to 7.0.1; @fortawesome/react-fontawesome remains at ^3.0.2. No other public APIs changed.

Changes

Cohort / File(s) Summary
FontAwesome dependency updates
frontend/package.json
Bumped @fortawesome/fontawesome-svg-core, @fortawesome/free-brands-svg-icons, @fortawesome/free-regular-svg-icons, and @fortawesome/free-solid-svg-icons from 6.7.2 to 7.0.1. @fortawesome/react-fontawesome entry/version unchanged (^3.0.2).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • kasya
  • arkid15r

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Linked Issues Check ⚠️ Warning The PR partially addresses [#2210] by bumping core @FortAwesome packages in frontend/package.json to v7, but it does not update @fortawesome/react-fontawesome and shows no application code changes or test fixes to handle migration incompatibilities, and the author has not confirmed local test runs; because the linked issue requires migrating all related packages and updating code/tests, the PR does not fully meet the linked issue objectives. Update any remaining @FortAwesome packages (notably @fortawesome/react-fontawesome if needed), run and fix failing tests, apply required code changes for v7 compatibility, and confirm CI and local test runs before considering the linked issue resolved.
✅ Passed checks (4 passed)
Check name Status Explanation
Title Check ✅ Passed The title accurately summarizes the primary change—updating Font Awesome dependencies to address test/build errors—and matches the package.json updates in the changeset, though it contains a minor spelling error ("dependies").
Out of Scope Changes Check ✅ Passed All changes in the provided summary are confined to frontend/package.json (upgrading @FortAwesome packages) with no unrelated files or modifications present, so no out-of-scope changes were detected.
Description Check ✅ Passed The PR description states it resolves #2210 and explains that it updates Font Awesome dependencies to fix a build failure, which is directly related to the package.json changes shown in the changeset.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d1a89d0 and 6f618fe.

⛔ Files ignored due to path filters (1)
  • frontend/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • frontend/package.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • frontend/package.json

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
frontend/package.json (1)

26-26: Nit: JSON spacing deviates from Prettier config.

Add a space after the colon to match the rest of the file and avoid churn on format runs.

-    "@fortawesome/react-fontawesome":"^3.0.2",
+    "@fortawesome/react-fontawesome": "^3.0.2",
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1a1df71 and 33aa934.

📒 Files selected for processing (1)
  • frontend/package.json (1 hunks)
🔇 Additional comments (2)
frontend/package.json (2)

22-26: Action: confirm FontAwesome v7 / react-fontawesome v3 impact (dynamic imports & fixed‑width icons)

  • frontend/package.json added @fortawesome/*@^7.0.1 and @fortawesome/react-fontawesome@^3.0.2.
  • Repo search returned no FontAwesome usages (FontAwesomeIcon, library.add, dynamic imports), but ripgrep showed file-skip warnings — manually verify there are no dynamic icon imports and update any snapshot/layout tests that assume pre‑v7 (non‑fixed) widths.

22-25: FA v7 bump looks correct — run a clean reinstall in frontend

frontend/package.json now pins @fortawesome/*@^7.0.1 and @fortawesome/react-fontawesome@^3.0.2 (FA v7 + React v3). Remove stale lockfile entries in the frontend and reinstall to avoid resolution mismatches.

cd frontend
rm -f pnpm-lock.yaml package-lock.json yarn.lock
pnpm install

@arkid15r arkid15r enabled auto-merge September 16, 2025 18:42
@sonarqubecloud
Copy link

@arkid15r
Copy link
Collaborator

@dharapandya85 you must run mandatory checks and tests for your code.

@arkid15r arkid15r added this pull request to the merge queue Sep 16, 2025
Merged via the queue into OWASP:main with commit ac5ace1 Sep 16, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate @fortawesome/* to v7

2 participants