Skip to content

Conversation

@VedmaPranav
Copy link
Contributor

This PR addresses Issue #3

Screenshot of the change:
Screenshot 2024-09-29 at 3 45 19 PM
Screenshot 2024-09-29 at 3 45 45 PM

Please feel free to suggest different styling, or any other feedback

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @VedmaPranav thanks for the PR!

Could you format code using make pre-commit and update the PR?

…theme

* 'main' of https://github.com/OWASP/Nest:
  Turn server tokens off
  Update issue index and Nginx config
  Update Nginx config
  Make some Repository fields optional
  Update Repository model
  Set up Sentry
  Update CI/CD
  Bump openai from 1.47.0 to 1.50.2 in /backend (OWASP#18)
  Bump pytest-cov from 4.1.0 to 5.0.0 in /backend (OWASP#16)
  Bump ruff from 0.5.7 to 0.6.8 in /backend (OWASP#17)
  Update issue-manager config
  Add issue manager
  Update dependabot config (docker)
  Update dependabot config
@VedmaPranav
Copy link
Contributor Author

@arkid15r I ran the pre-commit checks and updated the PR

@VedmaPranav
Copy link
Contributor Author

I mistakenly merged the main branch into this branch, I need to undo the merge.

@arkid15r
Copy link
Collaborator

arkid15r commented Oct 2, 2024

I mistakenly merged the main branch into this branch, I need to undo the merge.

So the pre-commit step of CI/CD is still failing. Could you address the pre-commit requirement issues?

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VedmaPranav thanks addressing the pre-commit issue

Please find my comment below and let me know your thoughts

@arkid15r arkid15r linked an issue Oct 9, 2024 that may be closed by this pull request
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @VedmaPranav
Please push the new code when you have a chance.

@VedmaPranav
Copy link
Contributor Author

Hey @arkid15r
I have removed any extra CSS that may not be used in the feature and changed the icons from images to font awesome like you suggested let me know if you need me to make anymore changes

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks nice!

Just a small comment regarding static path:

@VedmaPranav
Copy link
Contributor Author

@arkid15r I updated the base html file to use static tag

@arkid15r arkid15r enabled auto-merge October 14, 2024 01:54
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement! Thanks @VedmaPranav!

@arkid15r arkid15r changed the title light-dark-theme Implement light/dark theme support Oct 14, 2024
@arkid15r arkid15r disabled auto-merge October 14, 2024 01:58
@arkid15r arkid15r added this pull request to the merge queue Oct 14, 2024
Merged via the queue into OWASP:main with commit 3646f11 Oct 14, 2024
7 checks passed
shdwcodr pushed a commit to shdwcodr/Nest that referenced this pull request Jun 5, 2025
* light-dark-theme

* fix pre-commit issues

* Revert "fix pre-commit issues"

This reverts commit 27a2469.

* Fixed the pre-commit issues got Pass on all checks in pre-commit

* changed the icons to font awesome and using dark theme attribute

* updated base html file to use static tag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Implement light/dark theme support for legacy project/contribute pages

2 participants