-
-
Notifications
You must be signed in to change notification settings - Fork 243
Implement light/dark theme support #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @VedmaPranav thanks for the PR!
Could you format code using make pre-commit and update the PR?
…theme * 'main' of https://github.com/OWASP/Nest: Turn server tokens off Update issue index and Nginx config Update Nginx config Make some Repository fields optional Update Repository model Set up Sentry Update CI/CD Bump openai from 1.47.0 to 1.50.2 in /backend (OWASP#18) Bump pytest-cov from 4.1.0 to 5.0.0 in /backend (OWASP#16) Bump ruff from 0.5.7 to 0.6.8 in /backend (OWASP#17) Update issue-manager config Add issue manager Update dependabot config (docker) Update dependabot config
|
@arkid15r I ran the pre-commit checks and updated the PR |
|
I mistakenly merged the main branch into this branch, I need to undo the merge. |
This reverts commit 27a2469.
So the pre-commit step of CI/CD is still failing. Could you address the pre-commit requirement issues? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VedmaPranav thanks addressing the pre-commit issue
Please find my comment below and let me know your thoughts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @VedmaPranav
Please push the new code when you have a chance.
|
Hey @arkid15r |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks nice!
Just a small comment regarding static path:
|
@arkid15r I updated the base html file to use static tag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvement! Thanks @VedmaPranav!
* light-dark-theme * fix pre-commit issues * Revert "fix pre-commit issues" This reverts commit 27a2469. * Fixed the pre-commit issues got Pass on all checks in pre-commit * changed the icons to font awesome and using dark theme attribute * updated base html file to use static tag
This PR addresses Issue #3
Screenshot of the change:


Please feel free to suggest different styling, or any other feedback