Add Turbo for Faster Compilation, Testing, and Build Times#1415
Add Turbo for Faster Compilation, Testing, and Build Times#1415arkid15r merged 5 commits intoOWASP:mainfrom
Conversation
Summary by CodeRabbit
Summary by CodeRabbit
WalkthroughThis set of changes introduces configuration and dependency updates for the frontend project. A Changes
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (6)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (4)
⏰ Context from checks skipped due to timeout of 90000ms (5)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
frontend/docker/Dockerfile.unit.test (1)
13-13: Approve consolidated COPY with.pnpmrc
Combining the COPY commands reduces image layers and ensures.pnpmrcis available for unit-test installations.Optional: For consistency with other Dockerfiles, consider adding
--chmod=444to protect config files from modification.frontend/next.config.ts (1)
10-10: Consider adding a comment explaining the externalized packagesThe externalization of 'import-in-the-middle' and 'require-in-the-middle' packages is correct, but it would be helpful to add a brief comment explaining why these specific packages need to be treated as external server packages. This would improve code maintainability.
- serverExternalPackages: ['import-in-the-middle', 'require-in-the-middle'], + // These packages are used for module interception and need to be treated as external on the server + serverExternalPackages: ['import-in-the-middle', 'require-in-the-middle'],
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
frontend/pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (7)
cspell/custom-dict.txt(2 hunks)frontend/.pnpmrc(1 hunks)frontend/docker/Dockerfile(2 hunks)frontend/docker/Dockerfile.e2e.test(1 hunks)frontend/docker/Dockerfile.unit.test(1 hunks)frontend/next.config.ts(1 hunks)frontend/package.json(2 hunks)
🔇 Additional comments (9)
cspell/custom-dict.txt (2)
80-80: Approve addition of 'pnpmrc'
Adding 'pnpmrc' to the custom dictionary prevents false-positive spellcheck errors for the new.pnpmrcfile.
99-99: Approve addition of 'turbopack'
Including 'turbopack' ensures the custom dictionary recognizes the new Turbo mode configuration term.frontend/docker/Dockerfile (2)
14-14: Approve copying of.pnpmrcin build stage
Including.pnpmrcalongside other config files ensures consistent pnpm behavior during image builds.
31-31: Skip: minor formatting change
The indentation update foraddusersimply aligns it under the previousaddgroupcommand. No action required.frontend/package.json (3)
6-7: Approve Turbo flags in scripts
Enabling--turbofordevandbuildscripts correctly activates Turbopack mode. Please also verify that any project documentation (e.g., README) is updated to reflect these new commands.
94-94: Approveimport-in-the-middledevDependency
Addingimport-in-the-middlealigns with the serverExternalPackages configuration. Confirm it is only used at development/runtime interception and appropriately scoped as a devDependency.
102-102: Approverequire-in-the-middledevDependency
Includingrequire-in-the-middlecomplements the pnpm hoisting pattern and external package settings. Ensure it loads correctly in the server context.frontend/docker/Dockerfile.e2e.test (1)
13-13: LGTM - Proper inclusion of .pnpmrc configuration fileAdding the .pnpmrc file to the Docker build correctly ensures that the e2e test environment uses the same pnpm configuration as other environments. This is essential for the Turbo integration to work consistently across all containerized environments.
frontend/next.config.ts (1)
7-9: Good configuration of Turbopack with file extensionsThe Turbopack configuration with explicit file extensions looks good and will help optimize module resolution during builds. This is a key part of improving compilation speed as mentioned in the PR objectives.
|
* added turbo for improving build speed * update * rm dup * Update code --------- Co-authored-by: Arkadii Yakovets <arkadii.yakovets@owasp.org>
2 participants
This PR integrates Turbo to significantly improve compilation, testing, and build times across the project.