-
-
Notifications
You must be signed in to change notification settings - Fork 271
Added a link to the repository name that navigates to /repositories/ #1339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary by CodeRabbit
WalkthroughThe changes update the way the repository name is rendered in the Changes
Possibly related PRs
Suggested reviewers
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (5)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
frontend/src/components/RecentReleases.tsx (1)
62-67: Good addition of clickable repository links!The implementation correctly converts the repository name to lowercase for consistent URL formatting and handles potential undefined values with the ternary operator. This aligns with the PR objective to make repository names clickable and navigate to the /repositories/ path.
However, consider how this handles edge cases:
- If
repositoryNameis undefined, the link would point to/repositories/, which might be a valid route but could be confusing.- No validation is performed on
repositoryNamefor URL-unsafe characters.For better defensive programming, consider implementing a more robust check:
<Link className="text-blue-400 hover:underline" - href={`/repositories/${item?.repositoryName ? item.repositoryName.toLowerCase() : ''}`} + href={item?.repositoryName ? `/repositories/${item.repositoryName.toLowerCase()}` : '/repositories'} > <span>{item.repositoryName}</span> </Link>
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
frontend/src/components/RecentReleases.tsx(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
frontend/src/components/RecentReleases.tsx (1)
frontend/src/types/link.ts (1)
Link(1-6)
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: Run backend tests
- GitHub Check: Run frontend e2e tests
- GitHub Check: Run frontend unit tests
- GitHub Check: CodeQL (python)
- GitHub Check: CodeQL (javascript-typescript)
arkid15r
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
|
Pull Request is not mergeable
…WASP#1339) * Added a link to the repository name that navigates to /repositories/ * fix typo * added check if there is repositoryName * Update code --------- Co-authored-by: Arkadii Yakovets <[email protected]>
…WASP#1339) * Added a link to the repository name that navigates to /repositories/ * fix typo * added check if there is repositoryName * Update code --------- Co-authored-by: Arkadii Yakovets <[email protected]>
…WASP#1339) * Added a link to the repository name that navigates to /repositories/ * fix typo * added check if there is repositoryName * Update code --------- Co-authored-by: Arkadii Yakovets <[email protected]>



Added clickable repository links in the Recent Releases block on the main page.
Links navigate to /repositories/[repositoryName], with repository names converted to lowercase for consistency.