Skip to content

Fixes #1272 fixing Contributors , tooltip fix and user logo#1273

Merged
arkid15r merged 5 commits intoOWASP:mainfrom
KaranNegi20Feb:contributors-and-tooltip
Apr 3, 2025
Merged

Fixes #1272 fixing Contributors , tooltip fix and user logo#1273
arkid15r merged 5 commits intoOWASP:mainfrom
KaranNegi20Feb:contributors-and-tooltip

Conversation

@KaranNegi20Feb
Copy link
Contributor

Fixes issue:Tool tip issue on New Projects and New Chapters #1272

Screenshot 2025-04-03 at 12 23 22 AM Screenshot 2025-04-03 at 12 35 30 AM Screenshot 2025-04-03 at 12 35 39 AM

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 2, 2025

Summary by CodeRabbit

  • Style
    • Enhanced accessibility and visual presentation by adding descriptive hover titles to profile links and updating their color styling.
    • Streamlined the layout with refined spacing adjustments on the homepage for a cleaner and more cohesive display.

Walkthrough

This pull request updates the styling and accessibility attributes within the frontend code. In the LeadersList component, a title attribute is added to the Link component and its styling class is updated. In the Home page, class names for various div elements are modified by removing or replacing certain utility classes. No changes were made to the exported or public entities.

Changes

File(s) Change summary
frontend/…/components/LeadersList.tsx Updated the Link component by adding a title attribute (View profile of ${leader}) and replacing text-blue-400 with text-gray-400 in the className attribute.
frontend/…/pages/Home.tsx Adjusted layout styling by removing the gap-x-2 and flex-wrap classes from div elements to alter the appearance of chapter and project details.

Possibly related PRs

Suggested labels

frontend-tests

Suggested reviewers

  • kasya

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b081f1c and d0f8a6f.

📒 Files selected for processing (1)
  • frontend/src/pages/Home.tsx (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • frontend/src/pages/Home.tsx
⏰ Context from checks skipped due to timeout of 90000ms (5)
  • GitHub Check: Run frontend unit tests
  • GitHub Check: Run backend tests
  • GitHub Check: Run frontend e2e tests
  • GitHub Check: CodeQL (python)
  • GitHub Check: CodeQL (javascript-typescript)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@arkid15r arkid15r linked an issue Apr 2, 2025 that may be closed by this pull request
2 tasks
@KaranNegi20Feb KaranNegi20Feb force-pushed the contributors-and-tooltip branch from 573873e to 1133fd3 Compare April 2, 2025 19:49
@KaranNegi20Feb KaranNegi20Feb changed the title Contributors and tooltip fix and fixes issue #1272 Fixes issue #1272 fixing Contributors , tooltip fix and user logo Apr 2, 2025
@KaranNegi20Feb
Copy link
Contributor Author

Screenshot 2025-04-03 at 1 17 07 AM All corrections can be checked here @arkid15r, Thank you for reviewing.

@KaranNegi20Feb KaranNegi20Feb changed the title Fixes issue #1272 fixing Contributors , tooltip fix and user logo Fixes #1272 fixing Contributors , tooltip fix and user logo Apr 2, 2025
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It now takes 2 lines instead of 1.
Screenshot 2025-04-02 at 5 58 35 PM

@KaranNegi20Feb
Copy link
Contributor Author

Seems like using the older component wasn't a good idea, let me change it again.

@KaranNegi20Feb
Copy link
Contributor Author

KaranNegi20Feb commented Apr 3, 2025

Screenshot 2025-04-03 at 9 32 59 AM Sorry for the inconvenience guys, using the old Tailwind wasn't a good idea, alright it works now. Verified for other viewports aswell. Thanks @arkid15r for pointing out. Screenshot 2025-04-03 at 9 37 57 AM

@KaranNegi20Feb KaranNegi20Feb force-pushed the contributors-and-tooltip branch from ade55cb to b081f1c Compare April 3, 2025 04:09
@arkid15r arkid15r enabled auto-merge April 3, 2025 05:33
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 3, 2025

@arkid15r arkid15r added this pull request to the merge queue Apr 3, 2025
Merged via the queue into OWASP:main with commit 3189b70 Apr 3, 2025
22 checks passed
shdwcodr pushed a commit to shdwcodr/Nest that referenced this pull request Jun 5, 2025
…SP#1273)

* corrections made to home release and others

* correction and addition

* more improvements and corrections

* more changes after review

---------

Co-authored-by: Arkadii Yakovets <2201626+arkid15r@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tool tip issue on New Projects and New Chapters

3 participants