Skip to content

fixed the modal window where the close button was focused earlier#1196

Merged
arkid15r merged 1 commit intoOWASP:mainfrom
codic-yeeshu:fix/madal-window
Mar 28, 2025
Merged

fixed the modal window where the close button was focused earlier#1196
arkid15r merged 1 commit intoOWASP:mainfrom
codic-yeeshu:fix/madal-window

Conversation

@codic-yeeshu
Copy link
Contributor

Resolves #1193

  • Previously, when opening the modal, the close button was automatically focused. After this fix, it will only be highlighted when hovered. Here is a recording clip for reference.
Screen.Recording.2025-03-28.at.10.31.02.AM.mov

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 28, 2025

Summary by CodeRabbit

  • Style
    • Updated the modal's close trigger to now display interactive hover effects for improved visual feedback during user interactions.

Walkthrough

The pull request updates the styling of the Modal component’s close button. The CSS classes for the DialogCloseTrigger were modified to replace focus-based styles with hover-based styles. No changes were made to the component’s functionality or overall structure.

Changes

File(s) Change Summary
frontend/.../Modal.tsx Replaced focus styling classes (focus:outline-none, focus:ring-2) with hover styling classes (hover:outline-none, hover:ring-2) in the DialogCloseTrigger component.

Assessment against linked issues

Objective Addressed Explanation
#1193: Fix modal window (Remove focus styling)

Suggested labels

frontend

Suggested reviewers

  • arkid15r
  • kasya

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b549e70 and db6b88a.

📒 Files selected for processing (1)
  • frontend/src/components/Modal.tsx (1 hunks)
🔇 Additional comments (1)
frontend/src/components/Modal.tsx (1)

42-44: Improved user experience by changing focus to hover states for the close button.

The change from focus-based to hover-based styling improves the modal interaction by preventing the close button from being automatically highlighted when the modal opens. Now the button will only be highlighted when users intentionally hover over it, which aligns with the expected behavior described in issue #1193.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sonarqubecloud
Copy link

@arkid15r arkid15r enabled auto-merge March 28, 2025 15:24
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@arkid15r arkid15r disabled auto-merge March 28, 2025 15:38
@arkid15r arkid15r merged commit de79db3 into OWASP:main Mar 28, 2025
7 checks passed
Rajgupta36 pushed a commit to Rajgupta36/Nest-n that referenced this pull request Mar 30, 2025
…ASP#1196)

Co-authored-by: A M YEESHU <amyeeshu@As-MacBook-Pro.local>
shdwcodr pushed a commit to shdwcodr/Nest that referenced this pull request Jun 5, 2025
…ASP#1196)

Co-authored-by: A M YEESHU <amyeeshu@As-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix modal window

2 participants

Comments