-
-
Notifications
You must be signed in to change notification settings - Fork 657
entity leader component added #1143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
5f37c00
entity leader component added
nipunh baf0ea4
Merge branch 'main' into feature/entity-leader-component
nipunh 81143f0
code quality
nipunh 68cafc4
removed code smells
nipunh 4141d36
improved code logic
nipunh def1dd9
unknown keyword added
nipunh f798538
unstagged changes retry
nipunh 5a556a6
Merge branch 'main' into feature/entity-leader-component
arkid15r ac0b846
updated test case
nipunh 0db1d0d
Merge branch 'main' into feature/entity-leader-component
nipunh e3a27c4
code formatting updated
nipunh f940223
Merge branch 'main' into pr/nipunh/1143
arkid15r 7988053
Update code
arkid15r File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| import { ReactNode } from 'react' | ||
|
nipunh marked this conversation as resolved.
Outdated
|
||
| import { Link } from 'react-router-dom' | ||
| import { LeadersListProps } from 'types/leaders' | ||
|
|
||
| const LeadersList = ({ leaders }: LeadersListProps) => { | ||
| if (!leaders || leaders.trim() === '') return <>Unknown</> | ||
|
|
||
| const leadersArray = leaders.split(',').map((leader) => leader.trim()) | ||
|
|
||
| return ( | ||
| <> | ||
| {leadersArray.map((leader, index) => ( | ||
| <span key={leader}> | ||
| <Link to={`/community/users?q=${encodeURIComponent(leader)}`}>{leader}</Link> | ||
| {index < leadersArray.length - 1 && ', '} | ||
| </span> | ||
| ))} | ||
| </> | ||
| ) | ||
| } | ||
|
|
||
| export default LeadersList | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| export type LeadersListProps = { | ||
| leaders: string | ||
| }; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.