Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect & Respond sections via @thatsjet #840

Merged
merged 13 commits into from
Feb 1, 2022

Conversation

thatsjet
Copy link
Contributor

@thatsjet thatsjet commented Jan 31, 2022

Thank you for submitting a Pull Request (PR) to the Cheat Sheet Series.

🚩 If your PR is related to grammar/typo mistakes, please double-check the file for other mistakes in order to fix all the issues in the current cheat sheet.

Please make sure that for your contribution:

  • In case of a new Cheat Sheet, you have used the Cheat Sheet template.
  • All the markdown files do not raise any validation policy violation, see the policy.
  • All the markdown files follow these format rules.
  • All your assets are stored in the assets folder.
  • All the images used are in the PNG format.
  • Any references to websites have been formatted as TEXT
  • You verified/tested the effectiveness of your contribution (e.g., the defensive code proposed is really an effective remediation? Please verify it works!).
  • The CI build of your PR pass, see the build status here.

If your PR is related to an issue, please finish your PR text with the following line:

This PR covers issue #124

Thank you again for your contribution 😃

Copy link
Collaborator

@commjoen commjoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @thatsjet and team! A few minor comments and then we are good to go!

cheatsheets_draft/Secrets_Management_CheatSheet.md Outdated Show resolved Hide resolved
cheatsheets_draft/Secrets_Management_CheatSheet.md Outdated Show resolved Hide resolved
cheatsheets_draft/Secrets_Management_CheatSheet.md Outdated Show resolved Hide resolved
@commjoen
Copy link
Collaborator

commjoen commented Jan 31, 2022

@jmanico & @mackowski when this pr is all done, we can release the cheatsheet as MVP... Then Job's done!

@thatsjet
Copy link
Contributor Author

I've got all of these ready to submit, but I can't edit the file here and don't know how to pull it back across to my fork. Any chance I can get edit privileges in this repo?

Copy link
Contributor Author

@thatsjet thatsjet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates ready for review. I just made them via the review editor.

commjoen
commjoen previously approved these changes Jan 31, 2022
Copy link
Collaborator

@commjoen commjoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This can be merged!

Copy link
Collaborator

@bendehaan bendehaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution @thatsjet, awesome work! I've got a few comments regarding the index/titles to prevent dead links, and some nits regarding typos/conciseness. Could you take a look at those?

cheatsheets_draft/Secrets_Management_CheatSheet.md Outdated Show resolved Hide resolved
cheatsheets_draft/Secrets_Management_CheatSheet.md Outdated Show resolved Hide resolved
cheatsheets_draft/Secrets_Management_CheatSheet.md Outdated Show resolved Hide resolved
cheatsheets_draft/Secrets_Management_CheatSheet.md Outdated Show resolved Hide resolved
cheatsheets_draft/Secrets_Management_CheatSheet.md Outdated Show resolved Hide resolved
cheatsheets_draft/Secrets_Management_CheatSheet.md Outdated Show resolved Hide resolved
cheatsheets_draft/Secrets_Management_CheatSheet.md Outdated Show resolved Hide resolved
cheatsheets_draft/Secrets_Management_CheatSheet.md Outdated Show resolved Hide resolved
cheatsheets_draft/Secrets_Management_CheatSheet.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@commjoen commjoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @thatsjet and @bendehaan!

@commjoen commjoen dismissed bendehaan’s stale review February 1, 2022 08:19

As agreed over chat: will do the last change later

Copy link
Collaborator

@mackowski mackowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks @thatsjet

@mackowski mackowski merged commit 3424bfe into OWASP:master Feb 1, 2022
@thatsjet thatsjet deleted the thatsjet-detect-respond branch February 1, 2022 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants