-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect & Respond sections via @thatsjet #840
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @thatsjet and team! A few minor comments and then we are good to go!
@jmanico & @mackowski when this pr is all done, we can release the cheatsheet as MVP... Then Job's done! |
I've got all of these ready to submit, but I can't edit the file here and don't know how to pull it back across to my fork. Any chance I can get edit privileges in this repo? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates ready for review. I just made them via the review editor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This can be merged!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your contribution @thatsjet, awesome work! I've got a few comments regarding the index/titles to prevent dead links, and some nits regarding typos/conciseness. Could you take a look at those?
Co-authored-by: Ben de Haan <[email protected]>
Co-authored-by: Ben de Haan <[email protected]>
Co-authored-by: Ben de Haan <[email protected]>
Co-authored-by: Ben de Haan <[email protected]>
Co-authored-by: Ben de Haan <[email protected]>
Co-authored-by: Ben de Haan <[email protected]>
Co-authored-by: Ben de Haan <[email protected]>
Co-authored-by: Ben de Haan <[email protected]>
Co-authored-by: Ben de Haan <[email protected]>
Co-authored-by: Ben de Haan <[email protected]>
Co-authored-by: Ben de Haan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much @thatsjet and @bendehaan!
As agreed over chat: will do the last change later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! thanks @thatsjet
Thank you for submitting a Pull Request (PR) to the Cheat Sheet Series.
Please make sure that for your contribution:
If your PR is related to an issue, please finish your PR text with the following line:
This PR covers issue #124
Thank you again for your contribution 😃