secrets management: update lifetime section #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@commjoen ok, the changes are in |
|
@vixentael , it just got merged so we can extend on it. Thank you so much for your help! |
mackowski
pushed a commit
that referenced
this pull request
Jan 31, 2022
* Added sections 6.3 and 6.4 * Extended section 6 and added materials to section 7: * Added more read more items * Removed section 8, added section 6.5 * updated section 6.5 a bit to make sure minimal is in the mvp * Added references to opencre.org * removed todo's and wrong reference * quick update on section 4 * added a bit more content * cleanups * secrets management: update lifetime section (#831) * secrets management: add details on secrets lifetime * Update Secrets_Management_CheatSheet.md * Updated section 4.2: * added a few more lines for 4.3 * First content of section 4.3 * Add section 4.4 * Spelling and grammar, first pass * Second pass * Fix links * Grammar and styling pass 1 * Finalise styling and grammar Co-authored-by: vixentael <[email protected]> Co-authored-by: Ben de Haan <[email protected]>
commjoen
pushed a commit
that referenced
this pull request
Jan 31, 2022
* secrets management: add details on secrets lifetime * Update Secrets_Management_CheatSheet.md
commjoen
pushed a commit
that referenced
this pull request
Jan 31, 2022
* secrets management: add details on secrets lifetime * Update Secrets_Management_CheatSheet.md
commjoen
added a commit
that referenced
this pull request
Jan 31, 2022
(by @vixentael and @bendehaan and @commjoen) * Added sections 6.3 and 6.4 * Extended section 6 and added materials to section 7: * Added more read more items * Removed section 8, added section 6.5 * updated section 6.5 a bit to make sure minimal is in the mvp * Added references to opencre.org * removed todo's and wrong reference * quick update on section 4 * added a bit more content * cleanups * secrets management: update lifetime section (#831) * secrets management: add details on secrets lifetime * Update Secrets_Management_CheatSheet.md * Updated section 4.2: * added a few more lines for 4.3 * First content of section 4.3 * Add section 4.4 * Spelling and grammar, first pass * Second pass * Fix links * Grammar and styling pass 1 * Finalise styling and grammar Co-authored-by: vixentael <[email protected]> Co-authored-by: Ben de Haan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As someone who works in cryptography and builds complicated key management protocols, I can't stay away of this party 🥳
This PR just adds small changes and clarifications, as part of #124.
Things done:
After merging #829 and #830 we should merge master here to avoid conflicts.
@commjoen @jmanico @zbraiterman take a look!