Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: WIP: work on section 3 of secret cheatsheet #813

Merged
merged 5 commits into from
Jan 16, 2022
Merged

Conversation

commjoen
Copy link
Collaborator

Thank you for submitting a Pull Request (PR) to the Cheat Sheet Series.

This PR updates issue #124 >.

@commjoen commjoen changed the title Draft: work on section 3 of secret cheatsheet Draft: WIP: work on section 3 of secret cheatsheet Jan 15, 2022
Copy link

@darkgl0w darkgl0w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello.
There are a few minor typos.


### 3.2 Where should a secret be?

- DO YOU PUT THE SECRET IN GIT PROVISIONGIN SYSTEM?J

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- DO YOU PUT THE SECRET IN GIT PROVISIONGIN SYSTEM?J
- DO YOU PUT THE SECRET IN GIT PROVISIONING SYSTEM?

Copy link
Member

@jmanico jmanico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so far so good

@jmanico jmanico merged commit f478d0f into master Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants