-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor grammar updates to the Abuse Case Cheatsheet #1557
Minor grammar updates to the Abuse Case Cheatsheet #1557
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much, Zoe!
I see a lot of lint errors.
@zbraiterman can you take a look? |
Thanks. @mackowski. I'm looking into these. |
@mackowski I think I just fixed the issues. |
I'm trying to understand, why are we flattening the bulleted lists? It looks like there are nested levels, to convey main topics and subtopics, and this PR moves them all to the same level. Why? |
@szh I agree that the structural changes that were introduced as a result of my "fixing" the linting errors made no sense. I'm not sure how the linting errors occurred, since I did not change the structure of the bulleted list in my initial commit. |
https://github.com/OWASP/CheatSheetSeries/pull/1557/files#diff-9434b821b36c5a0e53aecbb2a2daeec5e79607f224f428d5b2e6fe2da34fd1b7L133-R135 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @zbraiterman!
You're A Rockstar
Thank you for submitting a Pull Request (PR) to the Cheat Sheet Series.
Please make sure that for your contribution:
[TEXT](URL)
If your PR is related to an issue, please finish your PR text with the following line:
This PR fixes issue #
<REPLACE WITH ISSUE NUMBER>
.Thank you again for your contribution 😃