Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commented out auto labellling functionality #2389

Merged
merged 15 commits into from
Jul 9, 2024

Conversation

Sarthak5598
Copy link
Member

No description provided.

Copy link

sentry-io bot commented Jul 1, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: website/views.py

Function Unhandled Issue
chatbot_conversation AttributeError: 'NoneType' object has no attribute 'as_retriever' /api/chat...
Event Count: 3

Did you find this useful? React with a 👍 or 👎

DonnieBLT
DonnieBLT previously approved these changes Jul 1, 2024
Copy link
Contributor

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would reverting the commit instead of commenting everything out work better here?

In general it's not a good practice to have commented code in the codebase.

@Sarthak5598
Copy link
Member Author

@arkid15r Sure If you feel thats the best , the old pr can be reverted

@DonnieBLT
Copy link
Collaborator

I think this is fine since the other PR can't be reverted and this gives some context as to what we were going for.

@Sarthak5598 Sarthak5598 merged commit 290e678 into OWASP-BLT:main Jul 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants