Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] nil ptr when sentinel config is emtpy #642

Merged
merged 1 commit into from
Sep 24, 2023

Conversation

shubham-cmyk
Copy link
Member

@shubham-cmyk shubham-cmyk commented Sep 23, 2023

Description

This PR fixes the nil ptr error that panic the operator when the redisSentinelConfig field is empty

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

@drivebyer
Copy link
Collaborator

LGTM

@shubham-cmyk shubham-cmyk merged commit 26f9c0b into OT-CONTAINER-KIT:master Sep 24, 2023
@shubham-cmyk shubham-cmyk deleted the nil-ptr branch October 1, 2023 12:33
mattrobinsonsre pushed a commit to mattrobinsonsre/redis-operator that referenced this pull request Jul 11, 2024
Signed-off-by: Shubham Gupta <[email protected]>
Signed-off-by: Matt Robinson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants