[Feature][Add] Secrets generation by the Operator #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubham-cmyk
changed the title
iamabhishek-dubey
requested changes
Dec 5, 2022
iamabhishek-dubey
requested changes
Jan 7, 2023
iamabhishek-dubey
pushed a commit
that referenced
this pull request
Jan 16, 2023
* Addresses issue [#390](#391) by adding support for multi-architecture container images. * Removed --platform due to linting rule constraints. * Removed echo statements due to lint rules. Signed-off-by: Michael Primeaux <[email protected]>
|
Any reason not to leverage https://redis.io/commands/acl-genpass/ ? |
|
This could be used that's why this PR was on hold for so long |
|
@darkrift I would like you to invite to slack channel : Join our #redis-operator Slack Channel. |
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #269
Secrets now can be generate by the operator.
Package added : https://github.com/google/uuid // for the Password generation.
Expected Working :
User can either create the secret itself or offload the generation to the operator.
Operator Create the Secret using the given name and namespace;
If namespace is empty the namespace of the redis setup is taken by the operator.
if no key is passed the default key is "key"