Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add- Adding dark mode to website #112 #117

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

0nikhilkumar
Copy link
Contributor

@0nikhilkumar 0nikhilkumar commented Oct 10, 2023

adding dark mode to the main page or website

Fixes #112

before :-
whiteMode

after :-
dark mode

How should this be tested?

  1. Go on home page
  2. On top right there is theme change button

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats your first contribution!



Thank you for opening a pull request, we will review your work soon so hang in there. :D

If you have concers, you can join our [discord server](https://discord.com/invite/4ujGbRJyDN).

@github-actions
Copy link

github-actions bot commented Oct 10, 2023

Visit the preview URL for this PR (updated for commit 1460840):

https://freefolio--pull-requests-60va51xr.web.app

(expires Thu, 19 Oct 2023 18:12:05 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 0970846dd0fc53318864266da8ba6cc9470d08c7

@0nikhilkumar
Copy link
Contributor Author

Sir I am hacktoberfest'23 participants so please merge this Pull Request and give the label of "hacktoberfest-accepted" then its counted for merging 1PR in hacktoberfest'23 event. @jofftiquez

Thank you sir.

@0nikhilkumar
Copy link
Contributor Author

@jofftiquez please review pr and merge and give label "hacktoberfest-accepted"

@jofftiquez
Copy link
Member

@jofftiquez please review pr and merge and give label "hacktoberfest-accepted"

Hello just reviewed the output. Just a few comments.

image

  • 1 Adjust the text to white when in dark mode
  • 2 and 3 background color not working
  • 4 Adjust dark background. Make it a bit lighter

Copy link
Member

@jofftiquez jofftiquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0nikhilkumar
Copy link
Contributor Author

Sir Changes are done @jofftiquez @jofftiquez

@0nikhilkumar
Copy link
Contributor Author

Sir I am hacktoberfest'23 participants so please merge this Pull Request and give the label of "hacktoberfest-accepted" then its counted for merging 1PR in hacktoberfest'23 event. @jofftiquez

Thank you sir.

Copy link
Member

@jofftiquez jofftiquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@jofftiquez jofftiquez merged commit 1dcec9b into OSSPhilippines:main Oct 13, 2023
2 checks passed
@jofftiquez
Copy link
Member

Thank you for your contribution @0nikhilkumar 💪🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to add Darkmode for the project
2 participants