Skip to content

Conversation

@ijiraq
Copy link
Member

@ijiraq ijiraq commented Oct 9, 2025

This provides Python version the ability to push out in ECSV format.

There is also some changes to how the sim and color classes are setup.

ijiraq and others added 30 commits April 1, 2023 16:48
… some helpers functions a func.py library, improved some comments, moved to using rebound to compute true anomally
Updated the version on CANFAR arc before doing a pull.
make a run pipe instead of multiple run commands.
…nary and use 'ECSV' as the file save format.
@ijiraq
Copy link
Member Author

ijiraq commented Oct 9, 2025

@jmpetit this is the correct Pull Request. Its the same content as the other one. Just a book keeping change. I'll look at the issue you found.

JJ, I've looked into the changes you made in the Fortran code. I like the idea, but you haven't changed the way the colors are read in any of the GiMeObj subroutine, so the program crahses (I've tested on the ijiraq/SurveySimulator fork). I guess you've changed the way the colors are defined in the python side, and that probably works.
Actually, I cannot install the python part, due to the pyproject.toml file. Somehow this interact with pip install and then prevents the recompilation of the FortranF95 module. If I remove the file from python directory, then the module is correctly created and the package is installed. Actaully, I note that pyporject.toml demands ""requires-python = ">=3.12"""" while I'm using python3.11. I remember having problems with python3.13, and possibly 3.12, so I reverted to python3.11. But don't remember the problems I had.
I've tried to change the requirement on python to >=3.11 and >=3.10, but this didn't work. I can only make the copilation of module work if I remove the pyproject.toml file. Weird.

Removing pyproject.toml, I installed the python version, and ran the tests.

test_color.py: OK
test_model.py: FAILED missing seed positional argument when calling OSSSSim.init()
test_ossssim.py: FAILED missing seed positional argument when calling OSSSSim.init()
test_ssim_util.py: OK
I think it is premature to include these proposed changes from ijiraq/SurveySimulator. How can one reject and close the PULL request ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant