Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ek80 quadrant dimemsions and coordinates to beam #619

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

emiliom
Copy link
Collaborator

@emiliom emiliom commented Apr 9, 2022

Addresses the first, easy part of #520:

For EK80 there is already a dimension called quadrant that is conceptually equivalent (for our purposes) to the beam dimension as defined in SONAR-netCDF4 v1. We will need to rename it to beam.

This PR involved just simple search-and-replace steps.

@emiliom emiliom added the data format Anything about data format label Apr 9, 2022
@emiliom emiliom added this to the 0.6.0 milestone Apr 9, 2022
@emiliom emiliom requested a review from b-reyes April 9, 2022 18:52
@emiliom emiliom mentioned this pull request Apr 9, 2022
2 tasks
@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2022

Codecov Report

Merging #619 (6df4e20) into dev (70799ec) will decrease coverage by 6.67%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #619      +/-   ##
==========================================
- Coverage   78.75%   72.07%   -6.68%     
==========================================
  Files          40       27      -13     
  Lines        3615     3223     -392     
==========================================
- Hits         2847     2323     -524     
- Misses        768      900     +132     
Flag Coverage Δ
unittests 72.07% <100.00%> (-6.68%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
echopype/convert/set_groups_ek80.py 96.10% <ø> (ø)
echopype/calibrate/calibrate_ek.py 80.14% <100.00%> (-13.36%) ⬇️
echopype/echodata/echodata.py 67.10% <100.00%> (-20.18%) ⬇️
echopype/echodata/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
echopype/calibrate/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
echopype/echodata/convention/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
echopype/echodata/convention/conv.py 11.11% <0.00%> (-88.89%) ⬇️
echopype/echodata/api.py 16.66% <0.00%> (-66.67%) ⬇️
echopype/calibrate/calibrate_base.py 53.76% <0.00%> (-33.34%) ⬇️
echopype/calibrate/calibrate_azfp.py 70.21% <0.00%> (-25.54%) ⬇️
... and 19 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@b-reyes b-reyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emiliom I don't see any issue with your proposed changes. I think you can go ahead and merge this.

@emiliom
Copy link
Collaborator Author

emiliom commented Apr 11, 2022

Thanks @b-reyes ! I'll merge.

@emiliom emiliom merged commit 2c6162c into OSOceanAcoustics:dev Apr 11, 2022
@emiliom emiliom deleted the quadrant2beam branch December 24, 2022 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data format Anything about data format
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants