Remove min max attributes for compute_MVBS

[ctuguinay]

Addresses #1378

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.92%. Comparing base (9f56124) to head (aed7143).
Report is 136 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1380       +/-   ##
===========================================
+ Coverage   83.52%   96.92%   +13.40%     
===========================================
  Files          64        3       -61     
  Lines        5686      195     -5491     
===========================================
- Hits         4749      189     -4560     
+ Misses        937        6      -931     

Flag	Coverage Δ
unittests	96.92% <ø> (+13.40%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ctuguinay]

@leewujung Just removed those few lines. This should be ready for a review.

Edit: Min/Max were actually eagerly calculated twice in the MVBS operation!

[leewujung]

Oh wow, thanks for finding out the second one!

The only thing I can think of is whether not having this attribute would impact automatic plotting in xarray or holoviz. I seem to remember when I was doing the MVBS downsampling for the ship echoshader plotting, something wasn't happy when the new MVBS dataarray did not have attributes. But I don't remember which one tripped it.

I just did a simple test using the dataset on this hvplot Image example page, and it plots without problem without the actual_range attributes.

So I think we are good to merge! We should probably add a standalone separate function to add actual_range back to the MVBS dataarray. This way if it is required in some way it will be easy to produce, and can be lazily evaluated.

[ctuguinay]

@leewujung Thanks for the review! I'll add an issue for the standalone function