Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Provenance combination_* attributes with combine_echodata #1113

Merged

Conversation

emiliom
Copy link
Collaborator

@emiliom emiliom commented Aug 4, 2023

Add combination_software_name, combination_software_version and combination_time attributes to Provenance group on combine_echodata. These attributes mirror the existing, convention-defined conversion_* attributes.

combine_echodata will retain the first (earliest) set of conversion_* attributes in the Provenance group together with the new combination_* attributes.

Addresses #810

@emiliom emiliom added enhancement This makes echopype better data format Anything about data format labels Aug 4, 2023
@emiliom emiliom added this to the 0.8.0 milestone Aug 4, 2023
@emiliom emiliom self-assigned this Aug 4, 2023
@emiliom emiliom requested a review from leewujung August 4, 2023 09:49
Copy link
Member

@leewujung leewujung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Feel free to merge.

@emiliom
Copy link
Collaborator Author

emiliom commented Aug 4, 2023

Great, thank you!

@emiliom emiliom merged commit a2e9260 into OSOceanAcoustics:dev Aug 4, 2023
3 checks passed
@emiliom emiliom deleted the combination-attrs-vs-conversion branch August 4, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data format Anything about data format enhancement This makes echopype better
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants