Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ui_param #1071

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Remove ui_param #1071

merged 1 commit into from
Jul 5, 2023

Conversation

leewujung
Copy link
Member

This PR addresses #1059 by removing ui_param from the code base.

This is pretty minor since we really do not use it anywhere anymore.

@leewujung leewujung added this to the 0.7.2 milestone Jul 5, 2023
@leewujung leewujung requested a review from emiliom July 5, 2023 17:19
emiliom
emiliom approved these changes Jul 5, 2023
View reviewed changes
Copy link
Collaborator

@emiliom emiliom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. You've captured all the occurrences of ui_param. Thanks!

@leewujung leewujung merged commit 8145693 into OSOceanAcoustics:dev Jul 5, 2023
3 checks passed
@leewujung leewujung mentioned this pull request Jul 5, 2023
Closed
@leewujung leewujung modified the milestones: 0.7.2, 0.8.0 Jul 15, 2023
lsetiawan pushed a commit to lsetiawan/echopype that referenced this pull request Jul 28, 2023
@leewujung @lsetiawan
remove ui_param from all code (OSOceanAcoustics#1071)
06b9047
@leewujung leewujung deleted the remove-ui_params branch July 21, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emiliom emiliom emiliom approved these changes

Assignees
No one assigned
Labels
data conversion
Projects
Echopype
Status: Done
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@leewujung @emiliom