Standardize backscatter_r/i long_name, and correct units

[emiliom]

Addresses #643.

• Standard long_name attribute in backscatter_r and backscatter_i variables for all instruments (except ad2cp) to use the SONAR-netCDF v1 strings. Now being set in single place, in the long_name attribute strings in the echodata/convention/1.0.yml file.
• Set AZFP backscatter_r units string to "count", per recent discussion with @leewujung and in "Processed" power data in EK60/80 backscatter_r #643
• For EK80, correct wrong unit backscatter_r / backscatter_i assignment being made in some cases, where the unit was set to "V" rather than "dB". @leewujung please double check this!

Note: I used # noqa for a couple of long lines, but black apparently ignored it. I guess we should remove the # noqa flags?

---

Side note: in my local test runs, I had two failures:

FAILED echopype/tests/calibrate/test_cal_params.py::test_get_cal_params_EK80_BB[in_da_freq_dep_with_scaling] (line 549)
  - AssertionError: assert False

FAILED echopype/tests/utils/test_utils_log.py::test_init_logger (line 25)
  - AssertionError: assert 4 == 2

I've had these failures happen sporadically since March! I don't know why.

[codecov-commenter]

Codecov Report

Merging #1047 (9237e79) into dev (a09d8f3) will decrease coverage by 2.94%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##              dev    #1047      +/-   ##
==========================================
- Coverage   80.79%   77.85%   -2.94%     
==========================================
  Files          67       18      -49     
  Lines        6086     2908    -3178     
==========================================
- Hits         4917     2264    -2653     
+ Misses       1169      644     -525     

Flag	Coverage Δ
unittests	77.85% <ø> (-2.94%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
echopype/convert/set_groups_azfp.py	97.46% <ø> (ø)
echopype/convert/set_groups_base.py	91.97% <ø> (-1.46%)	⬇️
echopype/convert/set_groups_ek60.py	92.56% <ø> (ø)
echopype/convert/set_groups_ek80.py	97.02% <ø> (ø)

... and 50 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[leewujung]

Thanks @emiliom : the changes look good. The "noqa" stuff is weird. I wonder if it does not work after an "," since all other working cases are not preceded by a comma.

One thing I saw while going through this is the messe organization of parsed2zarr code sprinkled in set_groups_base.py. This is something hopefully #966 will address.

[leewujung]

Thanks @emiliom : the changes look good. The "noqa" stuff is weird. I wonder if it does not work after an "," since all other working cases are not preceded by a comma.

One thing I saw while going through this is the messe organization of parsed2zarr code sprinkled in set_groups_base.py. This is something hopefully #966 will address.

[leewujung]

Thanks @emiliom : the changes look good. The "noqa" stuff is weird. I wonder if it does not work after an "," since all other working cases are not preceded by a comma.

One thing I saw while going through this is the messe organization of parsed2zarr code sprinkled in set_groups_base.py. This is something hopefully #966 will address (I've added this to the issue description TODOs).

[emiliom]

Thanks @emiliom : the changes look good.

Great!

The "noqa" stuff is weird. I wonder if it does not work after an "," since all other working cases are not preceded by a comma.

Good suggestion. I may give it a try.

One thing I saw while going through this is the messe organization of parsed2zarr code sprinkled in set_groups_base.py. This is something hopefully #966 will address (I've added this to the issue description TODOs).

Yeah, there was effectively a duplication of code. I didn't try to clean it up. As you said, hopefully some it will be addressed in #966. Thanks for flagging it in that issue's TODOs.

You approved this PR, so it sounds like I can merge it.

[leewujung]

it sounds like I can merge it
Yes, if you could either remove the #noqa or fix it, that'll be good ;)

[emiliom]

I've removed the # noqa flags that are being ignored. BTW, while doing that I saw other # noqa flags in one of these modules that follow lines that end in a comma. So, there must be something else going on. Oh well.