Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve parsing config XML in AZFP files #659

Closed
3 tasks done
leewujung opened this issue May 3, 2022 · 3 comments
Closed
3 tasks done

Improve parsing config XML in AZFP files #659

leewujung opened this issue May 3, 2022 · 3 comments
Assignees
Labels
data conversion enhancement This makes echopype better good first issue Good for newcomers
Milestone

Comments

@leewujung
Copy link
Member

leewujung commented May 3, 2022

Currently only a subset of variables are parsed from the AZFP XML files. These are the ones that were parsed in the reference Matlab code from the manufacturer ASL Env Sci.

We recently found that in order to encode a unique channel identifier, it would be the best to use the field Frequency Number in the AZFP XML file. However, the current simplistic XML parsing function does not support that. Let's take this chance to improve the robustness of this XML parsing, and also to include the variable units which were not included in the current parser.

For needing a unique channel identifier, see #566, which is addressed by #657.

This is similar to #468.

Tasks

  • improve robustness of AZFP XML parser, using something like lxml
  • improve AZFP XML parser to include all config variables
  • include variable units in the XML file to parser and store accordingly in the set_groups methods
@emiliom
Copy link
Collaborator

emiliom commented Sep 18, 2023

The first two tasks are addressed in #1151.

I think the third task, "include variable units in the XML file to parser and store accordingly in the set_groups methods", was partly addressed in v0.8.0/0.8.1. Other aspects related to it will be addressed via #1171.

@praneethratna
Copy link
Contributor

praneethratna commented Oct 14, 2023

Closing, since this was fixed in #1182.

@emiliom emiliom added this to the 0.8.2 milestone Oct 14, 2023
@emiliom
Copy link
Collaborator

emiliom commented Oct 15, 2023

I've checked off the third task (units), since it was still unchecked. See my note above, #659 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data conversion enhancement This makes echopype better good first issue Good for newcomers
Projects
Status: Done
Development

No branches or pull requests

3 participants