Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI is not correctly raising the exit code from test #1140

Open
lsetiawan opened this issue Aug 29, 2023 · 2 comments
Open

CI is not correctly raising the exit code from test #1140

lsetiawan opened this issue Aug 29, 2023 · 2 comments
Labels
bug Something isn't working tests

Comments

@lsetiawan
Copy link
Member

Overview

I noticed that currently in dev branch the tests are "passing". However, looking at the actual output log here There are actual some failures in the test, but it's still showing green checkmark.

I think the issue here is that using tee to capture the logs is not allowing the actual test exit code to be raised, but rather the success of writing to log file. Need to find a better way to do this so that we can both capture the log and raise the appropriate error code.

lsetiawan added a commit that referenced this issue Aug 29, 2023
Removed capturing the output of pytest into a log
using 'tee'. This way the proper exit code should be propagated.

The logs are currently now looked at much anyways! :)
------

Ref: Issue #1140
@emiliom
Copy link
Collaborator

emiliom commented Aug 30, 2023

I noticed this behavior in a recent PR! But it's clearly not consistent, since we do get CI failures due to test failures

@leewujung
Copy link
Member

Thanks for adding this issue. I noticed that too and ran all tests locally before merging.

lsetiawan added a commit that referenced this issue Aug 30, 2023
Removed capturing the output of pytest into a log
using 'tee'. This way the proper exit code should be propagated.

The logs are currently now looked at much anyways! :)
------

Ref: Issue #1140
@lsetiawan lsetiawan self-assigned this Aug 30, 2023
@leewujung leewujung added bug Something isn't working tests GSoC24 labels Feb 27, 2024
@lsetiawan lsetiawan removed their assignment Mar 15, 2024
@leewujung leewujung removed the GSoC24 label Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tests
Projects
Status: Todo
Development

No branches or pull requests

3 participants