Update osgeo-gdal.rb #1089
Update osgeo-gdal.rb #1089
Conversation
Formula/osgeo-gdal.rb
Outdated
| @@ -142,7 +142,7 @@ def configure_args | |||
| "--with-qhull=internal", | |||
| "--with-libz=#{Formula["libzip"].opt_prefix}", | |||
| "--with-png=#{Formula["libpng"].opt_prefix}", | |||
| "--with-libtiff=#{Formula["libtiff"].opt_prefix}", | |||
| "--with-libtiff=internal", # #{Formula["libtiff"].opt_prefix} | |||
| "--with-geotiff=#{Formula["osgeo-libgeotiff"].opt_prefix}", | |||
There was a problem hiding this comment.
@fjperini I've tried similar thing yesterday but then I had problem with TiffTags. Using external libgeotiff and internal libtiff might create some side effects
There was a problem hiding this comment.
@vincentsarago can you report the problems? suggestions?
There was a problem hiding this comment.
Well basically with this configuration I couldn't read any GeoTIFF thus I removed --with-geotiff and it seemed to fix it
There was a problem hiding this comment.
I guess it's better to use both libtiff and libgeotiff shipped with GDAL to avoid conflict
There was a problem hiding this comment.
maybe @palmerj could validate this
There was a problem hiding this comment.
yes, maybe we need to use "internal" in both.
There was a problem hiding this comment.
Thanks both. I've not had any issues using external geotiff and internal libtiff, but I haven't done wide testing. Seem logical to use internal for both.
|
@fjperini another comment not related but could we remove |
|
@vincentsarago will disable jasper |
|
proj5 #1090 |
|
👏 thanks for the changes @fjperini |
|
I will merge this |
|
Thank you very much |
Solution for the problem reported in #1087 #1085 #1086