-
-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ps.map: Fix copy into fixed size buffer issue in do_scalebar.c file #4307
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the inline comment, there is only one minor suggestion:
You have, in this case correctly decided, to silence most of the return values with void, I think you can do the same with the remaining one.
The value of
Line 66 in 5719ba6
int G_database_unit(void) |
is guaranteed to fit into a buffer of size 50.
Done |
This pull request resolves a buffer overflow issue detected by Coverity Scan (CID 1208259).
strcpy is replaced with G_strlcpy