Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gdal_tindex] Use argparser #9813

Merged
merged 4 commits into from
May 1, 2024
Merged

Conversation

elpaso
Copy link
Collaborator

@elpaso elpaso commented Apr 30, 2024

No description provided.

@rouault
Copy link
Member

rouault commented Apr 30, 2024

Do you mind reworking the commit history in 4 separate commits?:

  • change to argparse.hpp
  • addition of the new method in gdalargumentparser.h/cpp
  • use of this new method in the already converted utilities (I wouldn't mind if it is merged in the previous commit)
  • changes to gdaltindex_bin/_lib

@elpaso elpaso force-pushed the gdaltindex-argparse branch from 342db5c to 67ff7ba Compare May 1, 2024 07:04
@elpaso
Copy link
Collaborator Author

elpaso commented May 1, 2024

Do you mind reworking the commit history in 4 separate commits?:

* change to argparse.hpp

* addition of the new method in gdalargumentparser.h/cpp

* use of this new method in the already converted utilities (I wouldn't mind if it is merged in the previous commit)

* changes to gdaltindex_bin/_lib

done

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 69.08% (+0.005%) from 69.075%
when pulling 67ff7ba on elpaso:gdaltindex-argparse
into 5dfa73a on OSGeo:master.

@rouault rouault added this to the 3.10.0 milestone May 1, 2024
@rouault rouault merged commit 7d1281c into OSGeo:master May 1, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants