-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New MiraMonVector driver #9688
New MiraMonVector driver #9688
Conversation
21b7707
to
5443cfe
Compare
I've worked together with @AbelPau over the past weeks to put the driver into shape. You can find the details of the review in AbelPau#12 . The branch in its state of ~ one week ago was submitted to coverity-scan and issues were fixed .I've also run it through ossfuzz locally on my PC with the undefined and address santizers, on the new miramon dedicated fuzzer, and it now runs for a couple days without issues. So from my perspective, we are in a state acceptable for upstreaming. |
5443cfe
to
fad106a
Compare
|
||
In MiraMon the concepts of OGRMultiPoints and OGRMultiLineStrings are not supported, | ||
but the driver translates a multipoint into N points and a multistring into N arcs. | ||
So, when reading a MiraMon file of type *.pol*, the corresponding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a little confusing to me. How does the handling of multipolygons relate to the limitation on multipoint/linestrings?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A multipolygon has a list of stringline indices (in the *.pol file) and when the vertices of a multipolygon (or a polygon) are dumped the coordinates are extracted from the corresponding *.arc file using that list of indices (and other details). You can consult how it's organized a multipolygon (or a polygon) more precisely here: https://www.miramon.cat/new_note/eng/notes/[MiraMon_structured_vectors_file_format.pdf](https://www.miramon.cat/new_note/eng/notes/MiraMon_structured_vectors_file_format.pdf)
But the concept of having a a group of connected lines it's not present in MiraMon, for the moment.
Co-authored-by: Nyall Dawson <[email protected]>
f30137f
to
4b71cd2
Compare
…eaded in reverse mode
What does this PR do?
This driver allows to create and open MiraMon polygon, stringline and point vectors.
What are related issues/pull requests?
There are not related issues or pull requests.
Tasklist
Environment
Provide environment details, if relevant: