Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database: rework a bit consistency checks triggers #4080

Merged
merged 7 commits into from
Apr 2, 2024

Conversation

rouault
Copy link
Member

@rouault rouault commented Mar 10, 2024

  • Move insertion triggers implementing consistency checks in a dedicated file.
    Can make it easier to disable them to speed the proj.db speed process during some development scenarios.
  • move final consistency checks on transformations as insert time triggers
  • consistency_checks_triggers.sql: add consistency check for 1st step of a concatenated operation
  • consistency_checks_triggers.sql: checks for Geog3D to Geog2D+GravityRelatedHeight/Depth family of methods

@rouault rouault added this to the 9.5.0 milestone Mar 10, 2024
@rouault rouault force-pushed the consistency_checks_triggers branch 3 times, most recently from 2e31b9a to 3dba023 Compare March 14, 2024 17:16
@rouault
Copy link
Member Author

rouault commented Mar 14, 2024

Rebased on top of latest master with the EPSG v11.006 updates who fix some inconsistencies

@rouault rouault force-pushed the consistency_checks_triggers branch from 3dba023 to 8b0a936 Compare March 24, 2024 13:37
@rouault
Copy link
Member Author

rouault commented Mar 24, 2024

Rebased on top of latest master with the EPSG v11.007 updates

…a dedicated file

Can make it easier to disable them to speed the proj.db speed process
during some development scenarios.
…3D to Geog2D+GravityRelatedHeight/Depth family of methods are properly registered
@rouault rouault force-pushed the consistency_checks_triggers branch from 8b0a936 to 31e05b9 Compare April 2, 2024 12:29
@rouault
Copy link
Member Author

rouault commented Apr 2, 2024

Rebased on top of lastest master to take into account #4098 ("Make NKG Transformation names unique")

@rouault rouault force-pushed the consistency_checks_triggers branch from 31e05b9 to 20e9b31 Compare April 2, 2024 16:52
@rouault
Copy link
Member Author

rouault commented Apr 2, 2024

@kbevers the consistency checks detected 2 remaining occurences of duplicated NKG transformation names, which I propose to resolve with a8db330

@kbevers
Copy link
Member

kbevers commented Apr 2, 2024

Ah yes, I should have spotted those as well. Your suggestion is good.

@rouault rouault force-pushed the consistency_checks_triggers branch from 20e9b31 to 45f5694 Compare April 2, 2024 17:24
@rouault rouault merged commit 8f7ae0e into OSGeo:master Apr 2, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants