Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSDCloud drops during stage of downloading drivers from MS Update Catalog while in WinPE #122

Closed
gwblok opened this issue Mar 8, 2024 · 10 comments

Comments

@gwblok
Copy link
Collaborator

gwblok commented Mar 8, 2024

Describe the bug
When running OSDCloud, it MIGHT Fail to download drivers from Windows Update Catalog in WinPE

To Reproduce
Steps to reproduce the behavior:
Run OSDCloud and MAYBE it will happen. I've had mixed results on different hardware.
Test machine that consistently failed: HP ProDesk 400 G1 - 18E9

Expected behavior
It would download successfully

Screenshots
image

Additional context
https://twitter.com/gwblok/status/1766243562033922132

gwblok added a commit that referenced this issue Mar 8, 2024
@gwblok
Copy link
Collaborator Author

gwblok commented Mar 8, 2024

I'm working on a Fix, just uploaded a Try/Catch to hopefully allow it to continue when this happens.
@OSDeploy, I'd love for you to get your eyes on this sometime. @AkosBakos also witnessed this (it's his screen capture)

@gwblok
Copy link
Collaborator Author

gwblok commented Mar 8, 2024

The error message happens right after Line 88 in the Save-MSUpCatDriver.ps1 file. I've added the Try / Catch for now.
Unsure what the real fix would be. - Change has been pushed to GitHub - Marked with Issue 122

@0x4448
Copy link

0x4448 commented Mar 9, 2024

Pretty sure the error is here:

if ($WindowsUpdateDriver.Guid) {

When all the if-statements between lines 93-107 fail to find anything, the variable is null. Changing the condition in line 109 to one of these might fix it:

$null -ne $WindowsUpdateDriver

$null -ne $WindowsUpdateDriver -and $WindowsUpdateDriver.Guid

The same change should probably be applied to to line 206.

if ($WindowsUpdateDriver.Guid) {

@AkosBakos
Copy link
Collaborator

I am not even able to create/change the ISO file:
image

@AkosBakos
Copy link
Collaborator

@0x4448 check the newest release, 24.3.10.1.
It should work now

@gwblok
Copy link
Collaborator Author

gwblok commented Mar 11, 2024

David did some updates for 24.3.10.1 - Issue should be resolved now. I'll do some testing, but I'm closing for now.

@gwblok gwblok closed this as completed Mar 11, 2024
@AkosBakos
Copy link
Collaborator

AkosBakos commented Mar 11, 2024

@gwblok what do you think?

#=======================================================================
Write-SectionHeader "[PreOS] Prepare Firmware Tasks"
#=======================================================================
[Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12
[System.Net.WebRequest]::DefaultWebProxy.Credentials = [System.Net.CredentialCache]::DefaultCredentials
Register-PSRepository -Default -Verbose
Set-PSRepository -Name PSGallery -InstallationPolicy Trusted -Verbose
Install-Module -Name MSCatalog -Force -Verbose -SkipPublisherCheck -AllowClobber -Repository PSGallery

@gwblok
Copy link
Collaborator Author

gwblok commented Mar 11, 2024

@AkosBakos, where would that go?

Looks like there are a couple of scripts in OSD module that install that module, so we'd have to make sure we got all of them.

I wonder if we should have a separate function for installing that module, then use that function in all of the different places it's called.

Part of me thinks we should make it auto install onto the Flash Drive when we're building the OSDCloud Flash Drive.

@gwblok gwblok reopened this Mar 11, 2024
@AkosBakos
Copy link
Collaborator

AkosBakos commented Mar 11, 2024

Still the same issue in the WinPE phase: image

When I invoke the Start-OSDCloud for the second time, it goes throw. 😳

PS: my test device is a Lenovo 500W G3

@gwblok
Copy link
Collaborator Author

gwblok commented Mar 13, 2024

Considering Closed for now with recently update to OSD Module, please create a new issue if the problem comes up again.

@gwblok gwblok closed this as completed Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants