-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support host wildcards in Shell app #601
Conversation
We really should start moving functions into a utilities module so we can write tests. The current architecture of the Shell app doesn't make tests easy. I'll talk with @samirmansour and @matthu017 offline so everyone is on the same page about it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed on Slack simpler solution that can be backed by tests.
Export generateWildcardGlob helper function
* allowlist.test.js has 100% code coverage
…o feature/shell-wildcards
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks ready to me. As a follow up, because this adds tests, we need enable those tests in our rake tasks.
This PR adds support for using wildcards such as
*.ten.osc.edu
in the SSH allowlist. Closes #599Example:
Set ENV variable
OOD_SSHHOST_ALLOWLIST
toowens.osc.edu:*.ten.osc.edu
then you can SSH into any host that matches*.ten.osc.edu
from the Shell app without adding every FQDN manually.hostInAllowList()
andgenerateWildcardGlob()
You can run tests with code coverage tests with command
yarn jest --verbose --coverage
or run test suites withyarn test