Skip to content

Conversation

@mrgum
Copy link
Contributor

@mrgum mrgum commented Oct 29, 2025

this time without changes to changelog

Copy link
Contributor

@johrstrom johrstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution. I'm ready to merge this, but may have to fight through some tests (this shouldn't fail tests, they can just be flaky sometimes).

Copy link
Contributor

@johrstrom johrstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

Comment on lines +13 to +17
1. [Fork the ondemand repository](https://github.com/OSC/ondemand/fork)
1. Create your feature branch (`git checkout -b my-new-feature`)
1. Commit your changes (`git commit -am 'Add some feature'`)
1. Push to the branch (`git push origin my-new-feature`)
1. Create a new Pull Request
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry! went to merge this and noticed this - seems like these steps should continue to be numbered 1 - 5.

@johrstrom johrstrom self-requested a review October 31, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Awaiting Review

Development

Successfully merging this pull request may close these issues.

3 participants