-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Globus button to make transfers easier #2858
Conversation
…en an OOD admin defines 'globus_endpoints' in their config, a Globus button will appear in the user interface. When clicked, this button will open a link to the Globus transfer web app using the correct transfer endpoint and directory info
The e2e tests a broken for a bit while we work on new packaging in 3.1. That said - unit tests seem to be failing because there are not updates to |
…he endpoint paths are not a one-to-one match with the filesystem
Made the changes related to situations where endpoint paths do not match filesystem paths. The updated globus_endpoints parameter should now look something like this:
I removed the css I added and used a link instead of a button. The only other change I had make was to set the title/tooltips on a span around the link so that it would still appear when the link was disabled. |
Thank you for the update (and the documentation!). I'll take a look at this shortly. |
Sorry for the delay - there are more coming as this week (and last 2) I've been buried with OSC work. Then next week I'm on vacation
I still don't believe this is correct, at least for your HOME directories. I got this configuration to work for me (my user globus_endpoints:
- path: "/users/PZS0714/johrstrom"
endpoint: "06758ab7-9cb0-4f90-b79f-098b41e90dcd"
endpoint_path: "/" If I use this, the globus url has globus_endpoints:
- path: "/users"
endpoint: "06758ab7-9cb0-4f90-b79f-098b41e90dcd"
endpoint_path: "/" I still need to look into Project or Scratch filesystems (outside of HOME), but I suspsect we need to treat HOME directories as a special case. |
Hi Jeff, For that type of setup, I think you can do something like this:
|
Or, alternatively:
|
Yea I thought the same after I left that comment. Would like to avoid ERB if we can (most folks just don't know it), but that seems like our best bet at the moment. |
I added an example of how to use this in the docs (OSC/ood-documentation#819) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks and sorry for the delay. You may see another PR from me to fix this up just slightly and another issue to refactor that inline javascript. It's fine for now, we don't need to get to it immediately, but we would like to stop inlining javascipt in <script>
tags.
I see your reactions here, so I'll add another note here or we can open another ticket. One thing that I'm still not super keen on is having to use ERB for the HOME directory. I think I'll open a ticket to explore what other possibilities there could be to make configuration simpler. |
* Add reference documentation for the globus_endpoints parameter, to enable the Globus button (OSC/ondemand#2858) * Updated with new format of globus_endpoints property * Add an example using the home directory of the current user * use etc instead of currentuser Etc.getpwnam(Etc.getlogin).dir is safer to use than currentuser at the moment. --------- Co-authored-by: David Kelly <[email protected]> Co-authored-by: Jeff Ohrstrom <[email protected]>
Preliminary integration between Open OnDemand and Globus Transfer. When an OOD admin defines 'globus_endpoints' in their config, a Globus button will appear in the user interface. When clicked, this button will open a link to the Globus transfer web app using the correct transfer endpoint and directory info.
I will be submitting the documentation shortly, but briefly the easiest way to configure this is to add a globus_endpoints parameter to ondemand.d that looks like this:
For a single Globus endpoint
For multiple endpoints at different locations