check config before accessing it

[johrstrom]

#1950 persists in the shell app even after #1988. We missed this one check that was in mainline.

I tested this by sharing the shell app with my test user and overriding OOD_CLUSTERS with some unreadable files.

┆Issue is synchronized with this Asana task by Unito

[gerald-byrket]

I'm sure this has to do with my dev setup, but when i use this branch for the shell app, i get the following.
I'm running node version 12.22.12
If i use the latest branch of the shell app, it works fine.

Error: /lib64/libstdc++.so.6: version `CXXABI_1.3.9' not found (required by /users/PZS0714/gbyrket/ondemand/ondemand_osc/apps/shell/node_modules/node-pty/build/Release/pty.node)
at Object.Module._extensions..node (internal/modules/cjs/loader.js:1057:18)
at Module.load (internal/modules/cjs/loader.js:863:32)
at Function.Module._load (internal/modules/cjs/loader.js:708:14)
at Module.require (internal/modules/cjs/loader.js:887:19)
at Module.require (/opt/ood/ondemand/root/usr/share/passenger/helper-scripts/node-loader.js:80:25)
at require (internal/modules/cjs/helpers.js:74:18)
at Object. (/users/PZS0714/gbyrket/ondemand/ondemand_osc/apps/shell/node_modules/node-pty/lib/unixTerminal.js:26:11)
at Module._compile (internal/modules/cjs/loader.js:999:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
at Module.load (internal/modules/cjs/loader.js:863:32)

[johrstrom]

I'm sure you need to module purge because you're building on a compute/login node and it executes on the web node.

Here are the full steps that should get you there. You may even want to do it in a straight up shell session because vs code is in a singularity container and that could have something to do with it here too.

git checkout fix-shell-again
rm -rf node_modules
module purge
bin/setup

[gerald-byrket]

I'm sure you need to module purge because you're building on a compute/login node and it executes on the web node.

Here are the full steps that should get you there. You may even want to do it in a straight up shell session because vs code is in a singularity container and that could have something to do with it here too.

git checkout fix-shell-again
rm -rf node_modules
module purge
bin/setup

Thanks Jeff.

gotta remember reload ruby module. :)

module load ruby/2.7.3

Thanks @johrstrom. That did it.

[gerald-byrket]

looks good. functions properly. ready to merge.