Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix passenger_options using wrong method #1793

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Fix passenger_options using wrong method #1793

merged 1 commit into from
Jan 27, 2022

Conversation

robinkar
Copy link
Contributor

@robinkar robinkar commented Jan 27, 2022 •
edited
Loading

This PR fixes a bug we found while trying to enable passenger_options in nginx_stage.yml.

Error -- undefined method `starts_with?' for "passenger_friendly_error_pages":String
Did you mean?  start_with?
Run 'nginx_stage --help' to see a full list of available command line options.

starts_with? is available in Rails only, and is deprecated anyway from what I understand.

┆Issue is synchronized with this Asana task by Unito

@johrstrom johrstrom self-requested a review January 27, 2022 13:58
johrstrom
johrstrom approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@johrstrom johrstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'll backport this to 2.0.21 as well.

@johrstrom johrstrom merged commit 7d45ff7 into OSC:master Jan 27, 2022
johrstrom pushed a commit that referenced this pull request Jun 28, 2022
@njbooher
Backport #1793 to 2.0 (#2106)
c218475
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johrstrom johrstrom johrstrom approved these changes

Assignees
No one assigned
Labels
component/nginx_stage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robinkar @johrstrom @osc-bot