Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyter form to radio button selection #1611

Merged
merged 8 commits into from
Nov 30, 2021

Conversation

ghost
Copy link

@ghost ghost commented Nov 19, 2021

Added functionality to support radio buttons in forms.
Added unit test for radio buttons.

Jupyter Related Pull is: OSC/bc_osc_jupyter#84

Rollback sprocket-rails to 3.3.0
@johrstrom
Copy link
Contributor

Oh - also, you be careful of whitespace. It shows up in my editor as these blue lines here and there.

image

rubocop can automatically fix things like this. Just run this command from the root of the dashboard.

rubocop -A test/integration/batch_connect_test.rb

.rubocop.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@johrstrom johrstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think we're ready for this now.

@johrstrom johrstrom self-requested a review November 30, 2021 16:01
@johrstrom
Copy link
Contributor

Errr, well actually tests are failing for some reason? Re-running the tests now.

@johrstrom johrstrom merged commit 51d1f52 into master Nov 30, 2021
@johrstrom johrstrom deleted the jupyter-form-to-radio-button-selection branch November 30, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants