add min/max javascript functionality #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johrstrom
changed the title
|
I think this is ready for review now. The table implementation is a much better way to reason about how these configs tied to one element ( |
johrstrom
commented
Oct 12, 2021
| "any", | ||
| data-minnn-bc-not-found-for-cluster-mistype: 30, | ||
| data-max-bc-not-found-for-cluster-mistype: 30, | ||
| data-maximum-bc-not-found-for-cluster-mistype: 30 |
There was a problem hiding this comment.
probably need to add test cases for 'any' to be sure these aren't parsed.
johrstrom
commented
Oct 12, 2021
| assert_equal 40, find_max('bc_num_slots') | ||
| end | ||
|
|
||
| test 'using same node sets min/max' do |
There was a problem hiding this comment.
seems like this test should also change node type. I guess just to be sure that you change the node type and the same min/maxes are set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1431
In draft right now because it doesn't really read well and besides needs these other things: