Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address some obvious performance issues #1069

Merged
merged 1 commit into from
Apr 23, 2021
Merged

Conversation

ericfranz
Copy link
Contributor

Limit app instances to 1 so apps can safely utilize in memory session data which could actually break functionality with the dashboard app (the node.js apps don't expand to multiple instances by default which is why we didn't have this problem till now).

Limit app instances to 1 so apps can safely utilize in memory session data
Copy link
Contributor

@johrstrom johrstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this. I think we assumed it for a long time, but forcing it here is really good.

@johrstrom johrstrom marked this pull request as ready for review April 23, 2021 15:14
@johrstrom johrstrom merged commit ec5bccf into master Apr 23, 2021
@johrstrom johrstrom deleted the fix_performance_issues branch April 23, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants