Skip to content

[CTT][master378] Fix ServerConfiguration URI values for CTT push-management checks - #4592

Merged
romanett merged 1 commit into
OPCFoundation:master378from
mrsuciu:master378-fix-serverconfiguration-identity-uris
Sep 29, 2026
Merged

romanett merged 1 commit into
OPCFoundation:master378from
mrsuciu:master378-fix-serverconfiguration-identity-uris

Conversation

@mrsuciu

@mrsuciu mrsuciu commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

Populate ApplicationUri and ProductUri from application configuration, guarding absent optional nodes. Add push tests verifying both values match the advertised server identity.

Description

Addresses the reported CTT complaint for Push Model for Global Certificate and TrustList Management, where these ServerConfiguration properties returned null:

  • ApplicationUri (ns=0;i=25706)
  • ProductUri (ns=0;i=25725)
    Initializes both properties from the application configuration, with guards for absent optional nodes.
    Validation: regression tests verify Good status and nonempty values matching the advertised server identity. All five variants pass; the full push fixture reports 116 passed, 9 expected skips, and no failures on .NET 10. CTT itself has not been rerun.

Checklist

Put an x in the boxes that apply. You can complete these step by step after opening the PR.

  • [X ] I have signed the CLA and read the CONTRIBUTING doc.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added all necessary documentation.
  • I have verified that my changes do not introduce (new) build or analyzer warnings.
  • I ran all tests locally using the UA.slnx solution against at least .net framework and .net 10, and all passed.
  • I fixed all failing and flaky tests in the CI pipelines and all CodeQL warnings.
  • I have addressed all PR feedback received.

Populate ApplicationUri and ProductUri from application configuration, guarding absent optional nodes. Add push tests verifying both values match the advertised server identity.
@mrsuciu mrsuciu changed the title [CTT] Fix ServerConfiguration URI values for CTT push-management checks [CTT][master378] Fix ServerConfiguration URI values for CTT push-management checks Sep 29, 2026
@codecov

codecov Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.96%. Comparing base (077d67f) to head (2361a16).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##           master378    #4592      +/-   ##
=============================================
- Coverage      61.99%   61.96%   -0.03%     
=============================================
  Files            381      381              
  Lines          79441    79445       +4     
  Branches       13916    13918       +2     
=============================================
- Hits           49246    49225      -21     
- Misses         25767    25796      +29     
+ Partials        4428     4424       -4     
Files with missing lines Coverage Δ
...a.Server/Configuration/ConfigurationNodeManager.cs 75.28% <100.00%> (+0.14%) ⬆️

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcschier marcschier added the 1.5.378 Only affects 1.5.378 (pre 2.0) label Sep 29, 2026
@romanett
romanett merged commit db39629 into OPCFoundation:master378 Sep 29, 2026
72 checks passed
GoetzGoerisch pushed a commit to umati/connect that referenced this pull request Oct 5, 2026
…5.378.182 (#52)

This PR contains the following updates:

| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [OPCFoundation.NetStandard.Opc.Ua](https://github.com/OPCFoundation/UA-.NETStandard) | `1.5.378.176` → `1.5.378.182` | ![age](https://developer.mend.io/api/mc/badges/age/nuget/OPCFoundation.NetStandard.Opc.Ua/1.5.378.182?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/OPCFoundation.NetStandard.Opc.Ua/1.5.378.176/1.5.378.182?slim=true) |

---

### Release Notes

<details>
<summary>OPCFoundation/UA-.NETStandard (OPCFoundation.NetStandard.Opc.Ua)</summary>

### [`v1.5.378.182`](https://github.com/OPCFoundation/UA-.NETStandard/releases/tag/1.5.378.182): OPC UA 1.05 Maintenance Update

[Compare Source](OPCFoundation/UA-.NETStandard@1.5.378.176...1.5.378.182)

Maintenance Release for fixing bugs found on the main378 development branch.

#### Released packages

[OPCFoundation.NetStandard.Opc.Ua](https://www.nuget.org/packages/OPCFoundation.NetStandard.Opc.Ua/1.5.378.182)
[OPCFoundation.NetStandard.Opc.Ua.Core](https://www.nuget.org/packages/OPCFoundation.NetStandard.Opc.Ua.Core/1.5.378.182)
[OPCFoundation.NetStandard.Opc.Ua.Security.Certificates](https://www.nuget.org/packages/OPCFoundation.NetStandard.Opc.Ua.Security.Certificates/1.5.378.182)
[OPCFoundation.NetStandard.Opc.Ua.Configuration](https://www.nuget.org/packages/OPCFoundation.NetStandard.Opc.Ua.Configuration/1.5.378.182)
[OPCFoundation.NetStandard.Opc.Ua.Server](https://www.nuget.org/packages/OPCFoundation.NetStandard.Opc.Ua.Server/1.5.378.182)
[OPCFoundation.NetStandard.Opc.Ua.Client](https://www.nuget.org/packages/OPCFoundation.NetStandard.Opc.Ua.Client/1.5.378.182)
[OPCFoundation.NetStandard.Opc.Ua.Client.ComplexTypes](https://www.nuget.org/packages/OPCFoundation.NetStandard.Opc.Ua.Client.ComplexTypes/1.5.378.182)
[OPCFoundation.NetStandard.Opc.Ua.Bindings.Https](https://www.nuget.org/packages/OPCFoundation.NetStandard.Opc.Ua.Bindings.Https/1.5.378.182)
[OPCFoundation.NetStandard.Opc.Ua.PubSub](https://www.nuget.org/packages/OPCFoundation.NetStandard.Opc.Ua.PubSub/1.5.378.182)

#### What's Changed

- Remove unused fields from ReferenceNodeManager by [@&#8203;mrsuciu](https://github.com/mrsuciu) in [#&#8203;4472](OPCFoundation/UA-.NETStandard#4472)
- Master378 fix incomplete message buffering by [@&#8203;mrsuciu](https://github.com/mrsuciu) in [#&#8203;4550](OPCFoundation/UA-.NETStandard#4550)
- Fix ServerConfiguration URI values for CTT push-management checks by [@&#8203;mrsuciu](https://github.com/mrsuciu) in [#&#8203;4592](OPCFoundation/UA-.NETStandard#4592)
- Bound nested array preallocation, XML depth and inbound PubSub metadata by [@&#8203;romanett](https://github.com/romanett) in [#&#8203;4603](OPCFoundation/UA-.NETStandard#4603)
- Fix queued data delivery after durable subscription transfer by [@&#8203;mrsuciu](https://github.com/mrsuciu) in [#&#8203;4622](OPCFoundation/UA-.NETStandard#4622)
- Fix GDS client deadlock after a failed keep-alive by [@&#8203;romanett](https://github.com/romanett) in [#&#8203;4623](OPCFoundation/UA-.NETStandard#4623)
- merge Master378 to release by [@&#8203;romanett](https://github.com/romanett) in [#&#8203;4628](OPCFoundation/UA-.NETStandard#4628)

**Full Changelog**: <OPCFoundation/UA-.NETStandard@1.5.378.176...1.5.378.182>

</details>

---

### Configuration

📅 **Schedule**: (UTC)

- Branch creation
  - Between 12:00 AM and 03:59 AM (`* 0-3 * * *`)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4xMzIuMSIsInVwZGF0ZWRJblZlciI6IjQ0LjEzMi4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Reviewed-on: https://codeberg.org/umati/connect/pulls/52
Signed-off-by: umati-bot <git-bot@umati.org>
GoetzGoerisch pushed a commit to umati/connect that referenced this pull request Oct 5, 2026
…r to 1.5.378.182 (#53)

This PR contains the following updates:

| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [OPCFoundation.NetStandard.Opc.Ua.Server](https://github.com/OPCFoundation/UA-.NETStandard) | `1.5.378.176` → `1.5.378.182` | ![age](https://developer.mend.io/api/mc/badges/age/nuget/OPCFoundation.NetStandard.Opc.Ua.Server/1.5.378.182?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/OPCFoundation.NetStandard.Opc.Ua.Server/1.5.378.176/1.5.378.182?slim=true) |

---

### Release Notes

<details>
<summary>OPCFoundation/UA-.NETStandard (OPCFoundation.NetStandard.Opc.Ua.Server)</summary>

### [`v1.5.378.182`](https://github.com/OPCFoundation/UA-.NETStandard/releases/tag/1.5.378.182): OPC UA 1.05 Maintenance Update

[Compare Source](OPCFoundation/UA-.NETStandard@1.5.378.176...1.5.378.182)

Maintenance Release for fixing bugs found on the main378 development branch.

#### Released packages

[OPCFoundation.NetStandard.Opc.Ua](https://www.nuget.org/packages/OPCFoundation.NetStandard.Opc.Ua/1.5.378.182)
[OPCFoundation.NetStandard.Opc.Ua.Core](https://www.nuget.org/packages/OPCFoundation.NetStandard.Opc.Ua.Core/1.5.378.182)
[OPCFoundation.NetStandard.Opc.Ua.Security.Certificates](https://www.nuget.org/packages/OPCFoundation.NetStandard.Opc.Ua.Security.Certificates/1.5.378.182)
[OPCFoundation.NetStandard.Opc.Ua.Configuration](https://www.nuget.org/packages/OPCFoundation.NetStandard.Opc.Ua.Configuration/1.5.378.182)
[OPCFoundation.NetStandard.Opc.Ua.Server](https://www.nuget.org/packages/OPCFoundation.NetStandard.Opc.Ua.Server/1.5.378.182)
[OPCFoundation.NetStandard.Opc.Ua.Client](https://www.nuget.org/packages/OPCFoundation.NetStandard.Opc.Ua.Client/1.5.378.182)
[OPCFoundation.NetStandard.Opc.Ua.Client.ComplexTypes](https://www.nuget.org/packages/OPCFoundation.NetStandard.Opc.Ua.Client.ComplexTypes/1.5.378.182)
[OPCFoundation.NetStandard.Opc.Ua.Bindings.Https](https://www.nuget.org/packages/OPCFoundation.NetStandard.Opc.Ua.Bindings.Https/1.5.378.182)
[OPCFoundation.NetStandard.Opc.Ua.PubSub](https://www.nuget.org/packages/OPCFoundation.NetStandard.Opc.Ua.PubSub/1.5.378.182)

#### What's Changed

- Remove unused fields from ReferenceNodeManager by [@&#8203;mrsuciu](https://github.com/mrsuciu) in [#&#8203;4472](OPCFoundation/UA-.NETStandard#4472)
- Master378 fix incomplete message buffering by [@&#8203;mrsuciu](https://github.com/mrsuciu) in [#&#8203;4550](OPCFoundation/UA-.NETStandard#4550)
- Fix ServerConfiguration URI values for CTT push-management checks by [@&#8203;mrsuciu](https://github.com/mrsuciu) in [#&#8203;4592](OPCFoundation/UA-.NETStandard#4592)
- Bound nested array preallocation, XML depth and inbound PubSub metadata by [@&#8203;romanett](https://github.com/romanett) in [#&#8203;4603](OPCFoundation/UA-.NETStandard#4603)
- Fix queued data delivery after durable subscription transfer by [@&#8203;mrsuciu](https://github.com/mrsuciu) in [#&#8203;4622](OPCFoundation/UA-.NETStandard#4622)
- Fix GDS client deadlock after a failed keep-alive by [@&#8203;romanett](https://github.com/romanett) in [#&#8203;4623](OPCFoundation/UA-.NETStandard#4623)
- merge Master378 to release by [@&#8203;romanett](https://github.com/romanett) in [#&#8203;4628](OPCFoundation/UA-.NETStandard#4628)

**Full Changelog**: <OPCFoundation/UA-.NETStandard@1.5.378.176...1.5.378.182>

</details>

---

### Configuration

📅 **Schedule**: (UTC)

- Branch creation
  - Between 12:00 AM and 03:59 AM (`* 0-3 * * *`)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4xMzIuMSIsInVwZGF0ZWRJblZlciI6IjQ0LjEzMy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Reviewed-on: https://codeberg.org/umati/connect/pulls/53
Signed-off-by: umati-bot <git-bot@umati.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.5.378 Only affects 1.5.378 (pre 2.0)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants