Skip to content

Fix the Opc.Ua.Types defects found by the read-only audit - #4474

Merged
marcschier merged 5 commits into
masterfrom
romanett/opc-ua-types-bugs-6c0393
Sep 14, 2026
Merged

marcschier merged 5 commits into
masterfrom
romanett/opc-ua-types-bugs-6c0393

Fix the null ordering, structured attribute writes and character sets

6d82e99
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 12, 2026 in 0s

81.00% (+0.00%) compared to 2d90881

View this Pull Request on Codecov

81.00% (+0.00%) compared to 2d90881

Details

Codecov Report

❌ Patch coverage is 80.80260% with 177 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.00%. Comparing base (2d90881) to head (6d82e99).

Files with missing lines Patch % Lines
src/Opc.Ua.Types/Encoders/XmlDecoder.cs 38.46% 21 Missing and 3 partials ⚠️
src/Opc.Ua.Types/Wot/WotJsonResidue.cs 65.67% 19 Missing and 4 partials ⚠️
src/Opc.Ua.Types/Encoders/JsonDecoder.cs 77.52% 12 Missing and 8 partials ⚠️
src/Opc.Ua.Types/Encoders/XmlParser.cs 65.78% 10 Missing and 3 partials ⚠️
src/Opc.Ua.Types/Wot/WotNodeSetConverter.WoT.cs 82.53% 8 Missing and 3 partials ⚠️
src/Opc.Ua.Types/BuiltIn/Variant.cs 94.70% 5 Missing and 4 partials ⚠️
src/Opc.Ua.Types/Utils/CoreUtils.cs 65.21% 5 Missing and 3 partials ⚠️
src/Opc.Ua.Types/Wot/WotProjectionResolver.cs 50.00% 4 Missing and 4 partials ⚠️
src/Opc.Ua.Types/Schema/SchemaValidator.cs 0.00% 3 Missing and 2 partials ⚠️
src/Opc.Ua.Types/Encoders/EncodeableFactory.cs 73.33% 3 Missing and 1 partial ⚠️
... and 28 more
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #4474    +/-   ##
========================================
  Coverage   80.99%   81.00%            
========================================
  Files        2050     2051     +1     
  Lines      300779   301376   +597     
  Branches    52053    52177   +124     
========================================
+ Hits       243628   244138   +510     
+ Misses      39185    39164    -21     
- Partials    17966    18074   +108     
Files with missing lines Coverage Δ
src/Opc.Ua.Types/BuiltIn/DiagnosticInfo.cs 94.52% <100.00%> (ø)
src/Opc.Ua.Types/BuiltIn/MatrixOf.cs 79.67% <100.00%> (+0.87%) ⬆️
src/Opc.Ua.Types/BuiltIn/QualifiedName.cs 99.27% <100.00%> (+0.01%) ⬆️
src/Opc.Ua.Types/Encoders/EncodingLimits.cs 100.00% <100.00%> (ø)
src/Opc.Ua.Types/Encoders/Union.cs 72.32% <100.00%> (+1.52%) ⬆️
src/Opc.Ua.Types/Nodes/NodeSet.cs 74.17% <100.00%> (ø)
src/Opc.Ua.Types/Nodes/NodeTable.cs 90.56% <100.00%> (+2.83%) ⬆️
src/Opc.Ua.Types/Nodes/ReferenceNode.cs 89.88% <ø> (-0.12%) ⬇️
src/Opc.Ua.Types/Nodes/VariableNode.cs 75.17% <100.00%> (+3.54%) ⬆️
src/Opc.Ua.Types/Schema/NodeSetComparer.cs 92.85% <100.00%> (+0.42%) ⬆️
... and 44 more

... and 38 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.