fix(server): enforce browse continuation point limit at capacity (#4036) - #4270
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master378 #4270 +/- ##
=============================================
- Coverage 60.19% 60.19% -0.01%
=============================================
Files 378 378
Lines 79067 79067
Branches 13838 13838
=============================================
- Hits 47598 47594 -4
- Misses 27047 27049 +2
- Partials 4422 4424 +2
🚀 New features to boost your workflow:
|
Backport of 1eb5e0c from master. Fixes an off-by-one error in browse continuation-point retention by evicting the oldest point as soon as the session reaches MaxBrowseContinuationPoints, and adds a regression test covering the exact-limit case that previously allowed one extra browse continuation point to remain active. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
marcschier
approved these changes
Aug 18, 2026
This was referenced Sep 11, 2026
GoetzGoerisch
pushed a commit
to umati/connect
that referenced
this pull request
Sep 23, 2026
…5.378.176 (#45) This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [OPCFoundation.NetStandard.Opc.Ua](https://github.com/OPCFoundation/UA-.NETStandard) | `1.5.378.156` → `1.5.378.176` |  |  | --- ### Release Notes <details> <summary>OPCFoundation/UA-.NETStandard (OPCFoundation.NetStandard.Opc.Ua)</summary> ### [`v1.5.378.176`](https://github.com/OPCFoundation/UA-.NETStandard/releases/tag/1.5.378.176): OPC UA 1.05 Maintenance Update [Compare Source](OPCFoundation/UA-.NETStandard@1.5.378.156...1.5.378.176) Maintenance Release for fixing bugs found on the main378 development branch. #### Released packages [OPCFoundation.NetStandard.Opc.Ua](https://www.nuget.org/packages/OPCFoundation.NetStandard.Opc.Ua/1.5.378.176) [OPCFoundation.NetStandard.Opc.Ua.Core](https://www.nuget.org/packages/OPCFoundation.NetStandard.Opc.Ua.Core/1.5.378.176) [OPCFoundation.NetStandard.Opc.Ua.Security.Certificates](https://www.nuget.org/packages/OPCFoundation.NetStandard.Opc.Ua.Security.Certificates/1.5.378.176) [OPCFoundation.NetStandard.Opc.Ua.Configuration](https://www.nuget.org/packages/OPCFoundation.NetStandard.Opc.Ua.Configuration/1.5.378.176) [OPCFoundation.NetStandard.Opc.Ua.Server](https://www.nuget.org/packages/OPCFoundation.NetStandard.Opc.Ua.Server/1.5.378.176) [OPCFoundation.NetStandard.Opc.Ua.Client](https://www.nuget.org/packages/OPCFoundation.NetStandard.Opc.Ua.Client/1.5.378.176) [OPCFoundation.NetStandard.Opc.Ua.Client.ComplexTypes](https://www.nuget.org/packages/OPCFoundation.NetStandard.Opc.Ua.Client.ComplexTypes/1.5.378.176) [OPCFoundation.NetStandard.Opc.Ua.Bindings.Https](https://www.nuget.org/packages/OPCFoundation.NetStandard.Opc.Ua.Bindings.Https/1.5.378.176) [OPCFoundation.NetStandard.Opc.Ua.PubSub](https://www.nuget.org/packages/OPCFoundation.NetStandard.Opc.Ua.PubSub/1.5.378.176) #### What's Changed - Fix publish queue lost wake-up by [@​marcschier](https://github.com/marcschier) in [#​4017](OPCFoundation/UA-.NETStandard#4017) - Obsolete legacy TraceConfiguration in favor of ITelemetryContext by [@​marcschier](https://github.com/marcschier) with [@​Copilot](https://github.com/Copilot) in [#​4090](OPCFoundation/UA-.NETStandard#4090) - Preserve publish queue timestamp ordering by [@​marcschier](https://github.com/marcschier) with [@​Copilot](https://github.com/Copilot) in [#​4084](OPCFoundation/UA-.NETStandard#4084) - Fix BadContinuationPointInvalid caused by empty continuation point in Browser.BrowseAsync by [@​marcschier](https://github.com/marcschier) in [#​4168](OPCFoundation/UA-.NETStandard#4168) - Add documentation for custom NodeSet2 authoring workflow by [@​romanett](https://github.com/romanett) with [@​Copilot](https://github.com/Copilot) in [#​4170](OPCFoundation/UA-.NETStandard#4170) - Fixed timer leaks in ChannelAsyncOperation.EndAsync ([#​3669](OPCFoundation/UA-.NETStandard#3669)) by [@​KarenKrill](https://github.com/KarenKrill) in [#​4166](OPCFoundation/UA-.NETStandard#4166) - Treat zero MaxNotificationsPerPublish as unlimited (OPC 10000-4) by [@​romanett](https://github.com/romanett) in [#​4263](OPCFoundation/UA-.NETStandard#4263) - fix(server): enforce browse continuation point limit at capacity ([#​4036](OPCFoundation/UA-.NETStandard#4036)) by [@​romanett](https://github.com/romanett) in [#​4270](OPCFoundation/UA-.NETStandard#4270) - Fix unordered server endpoint validation ([#​4029](OPCFoundation/UA-.NETStandard#4029)) \[backport to master378] by [@​romanett](https://github.com/romanett) in [#​4269](OPCFoundation/UA-.NETStandard#4269) - fix: don't return continuation points on BadNoContinuationPoints ([#​4022](OPCFoundation/UA-.NETStandard#4022)) \[backport to master378] by [@​romanett](https://github.com/romanett) in [#​4268](OPCFoundation/UA-.NETStandard#4268) - fix: scope Cancel request matching to the current session ([#​4023](OPCFoundation/UA-.NETStandard#4023)) by [@​romanett](https://github.com/romanett) in [#​4267](OPCFoundation/UA-.NETStandard#4267) - Set ContinuationPoint to null when browse is finished (port of [#​4057](OPCFoundation/UA-.NETStandard#4057)) by [@​romanett](https://github.com/romanett) in [#​4266](OPCFoundation/UA-.NETStandard#4266) - Default TransportQuotas in ApplicationConfiguration.ValidateAsync to prevent server-start NullReferenceException (backport to master378) by [@​romanett](https://github.com/romanett) in [#​4264](OPCFoundation/UA-.NETStandard#4264) - Fix ServerTimestamp update on read of stored/static nodes ([#​4257](OPCFoundation/UA-.NETStandard#4257)) by [@​romanett](https://github.com/romanett) in [#​4260](OPCFoundation/UA-.NETStandard#4260) - Fix reverse connect hold time when several Servers share one listener by [@​romanett](https://github.com/romanett) in [#​4341](OPCFoundation/UA-.NETStandard#4341) - \[master378] Fix Publish with maximum TimeoutHint by [@​mrsuciu](https://github.com/mrsuciu) in [#​4373](OPCFoundation/UA-.NETStandard#4373) - \[master378] Send the filtered retain trailing event with a client specific Retain = false by [@​romanett](https://github.com/romanett) in [#​4454](OPCFoundation/UA-.NETStandard#4454) - Master378 backport ctt changes by [@​mrsuciu](https://github.com/mrsuciu) in [#​4326](OPCFoundation/UA-.NETStandard#4326) - Update Microsoft.SourceLink.GitHub and Microsoft.SourceLink.AzureRepos.Git from 10.0.102 to 10.0.111 by [@​mrsuciu](https://github.com/mrsuciu) in [#​4465](OPCFoundation/UA-.NETStandard#4465) **Full Changelog**: <OPCFoundation/UA-.NETStandard@1.5.378.156...1.5.378.176> </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - Between 12:00 AM and 03:59 AM (`* 0-3 * * *`) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC43Ny4wIiwidXBkYXRlZEluVmVyIjoiNDQuNzcuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Reviewed-on: https://codeberg.org/umati/connect/pulls/45 Signed-off-by: umati-bot <git-bot@umati.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the browse continuation point limit fix from master (commit 1eb5e0c, PR #4036) to
master378.Problem
An off-by-one error in browse continuation-point retention allowed one extra browse continuation point to remain active. The eviction check only removed the oldest point when the count exceeded
MaxBrowseContinuationPoints, so a session could holdMaxBrowseContinuationPoints + 1points.Fix
In
Session.SaveContinuationPoint, evict the oldest point as soon as the session reaches the configured limit (>=instead of>), so at mostMaxBrowseContinuationPointspoints remain active.Tests
Adds
SessionContinuationPointsTests.SaveContinuationPointEvictsOldestWhenCountReachesConfiguredLimit, a regression test that saves one more than the configured limit and asserts the oldest point is evicted while exactly the configured number are retained. Verified it fails against the pre-fix code and passes with the fix.Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com