Fix build failure: update SubscriptionManager.CompleteAsync callers to new (IMessageProcessor, uint, CancellationToken) signature - #4118
Closed
marcschier with Copilot wants to merge 2 commits into
Closed
marcschier with Copilot wants to merge 2 commits into
marcschier with Copilot wants to merge 2 commits into
Conversation
|
|
…d failure Update IMessageAckQueue.CompleteAsync signature to include IMessageProcessor as first parameter, matching the PR #4114 intent. Update all callers: - MessageProcessor.cs: store last server id, pass self to CompleteAsync - SubscriptionManager.cs: use completing IMessageProcessor for O(1) lookup, skip zero-id history entries - FakeMessageAckQueue.cs: update fake impl to match new interface - SubscriptionManagerTests.cs: update existing tests + add new test for zero-id - SubscriptionManagerCoverageTests.cs: fix the two calls causing CI failure
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job build-windows-all-tfm
Fix build failure: update SubscriptionManager.CompleteAsync callers to new (IMessageProcessor, uint, CancellationToken) signature
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #4114 changed
IMessageAckQueue.CompleteAsyncfrom(uint, CancellationToken)to(IMessageProcessor, uint, CancellationToken)to fix incorrect eviction of zero-id subscriptions, but did not updateSubscriptionManagerCoverageTests.cs, causingCS7036build failures in thebuild-windows-all-tfmCI job.Changes
IMessageAckQueue.cs— updatedCompleteAsyncsignature to(IMessageProcessor subscription, uint subscriptionId, CancellationToken ct)MessageProcessor.cs— tracks last non-zero server-assigned id (m_lastServerId); passesthisandm_lastServerIdtoCompleteAsyncinstead of the current (potentially zero)IdSubscriptionManager.cs— implements new signature: identity-based O(1) removal viacompleting as IManagedSubscription; skips zero-id entries in subscription historyFakeMessageAckQueue.cs— updated fake to satisfy new interfaceSubscriptionManagerTests.cs— updated existing call sites; addedCompleteForUncreatedIdDoesNotEvictPendingSubscriptionAsynccovering the zero-id eviction scenarioSubscriptionManagerCoverageTests.cs— fixed the two call sites that caused the CI failureChecklist